Skip to content

Commit 965059d

Browse files
authored
fix: update manual approval workflow to include version input and improve messaging (#321)
1 parent 6c09c51 commit 965059d

2 files changed

Lines changed: 20 additions & 6 deletions

File tree

.github/workflows/manual_approver.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@ name: Manual Approval Step
22

33
on:
44
workflow_call:
5+
inputs:
6+
version:
7+
description: "Version being published"
8+
required: false
9+
default: "latest"
10+
type: string
511

612
jobs:
713
wait-for-approval:
@@ -13,6 +19,6 @@ jobs:
1319
secret: ${{ secrets.GITHUB_TOKEN }}
1420
approvers: subhankarb,Ryuk-me,driptanil,WeryZebra-Yue
1521
minimum-approvals: 1
16-
issue-title: "Approval needed for Release v${{ github.event.inputs.version }}"
17-
issue-body: "Please approve or deny the creation of release branch and tag for v${{ github.event.inputs.version }}"
22+
issue-title: "Approval needed for Release ${{ inputs.version }}"
23+
issue-body: "Please approve or deny the creation of release and publishing to PyPI for version ${{ inputs.version }}"
1824
exclude-workflow-initiator-as-approver: false

.github/workflows/pypi_publish.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
name: publish to pypi
1+
name: Publish to PyPI
22

3-
run-name: publish to pypi
3+
run-name: Publish to PyPI
44

55
on:
66
workflow_dispatch:
@@ -9,14 +9,22 @@ on:
99
description: "Python version to use (default: 3.12)"
1010
required: false
1111
default: "3.12"
12+
type: string
13+
version:
14+
description: "Version being published (for approval message)"
15+
required: false
16+
default: "latest"
17+
type: string
1218

1319
jobs:
1420
wait-for-approval:
15-
uses: .github/workflows/manual_approver.yaml
21+
uses: ./.github/workflows/manual_approver.yaml
22+
with:
23+
version: ${{ inputs.version }}
1624

1725
publish-to-pypi:
1826
needs: wait-for-approval
19-
uses: .github/workflows/poetry_publish.yaml
27+
uses: ./.github/workflows/poetry_publish.yaml
2028
with:
2129
python_version: ${{ inputs.python_version || '3.12' }}
2230
secrets:

0 commit comments

Comments
 (0)