Skip to content

fix: update manual approval workflow to include version input and imp…#321

Merged
Kanai2003 merged 1 commit into
mainfrom
fix-ci
Aug 25, 2025
Merged

fix: update manual approval workflow to include version input and imp…#321
Kanai2003 merged 1 commit into
mainfrom
fix-ci

Conversation

@Kanai2003

@Kanai2003 Kanai2003 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

…rove messaging

Fixes/Implements

Description

Summary Goes here.

Type of change

Delete irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Locally Tested
  • Needs Testing From Production

Summary by CodeRabbit

  • New Features

    • Publishing workflow now accepts an optional version parameter (default: “latest”) and surfaces it in approval messages for clearer context.
  • Chores

    • Renamed the publishing workflow to “Publish to PyPI” and updated the run name for consistency.
    • Standardized references to reusable workflows using explicit relative paths.
    • Explicitly defined the python_version input type; default behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Aug 25, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new optional version input to the reusable manual approval workflow and wires it through from the PyPI publish workflow. Updates approval issue title/body to use the new input. Normalizes workflow names and explicitly types inputs. Updates reusable workflow references to explicit relative paths.

Changes

Cohort / File(s) Summary
Manual approval workflow
.github/workflows/manual_approver.yaml
Adds workflow_call input version (string, default "latest", not required). Replaces references from github.event.inputs.version to inputs.version in issue title/body. Adjusts body text to mention release creation and PyPI publishing.
PyPI publish workflow
.github/workflows/pypi_publish.yml
Renames workflow and run-name to "Publish to PyPI". Adds workflow_dispatch input version (string, default "latest"); explicitly types python_version as string. Passes version to wait-for-approval. Changes reusable workflow uses to ./.github/workflows/....

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub Actions (Publish to PyPI)
  participant Approver as Manual Approver
  participant MA as Reusable: manual_approver.yaml
  participant PP as Reusable: poetry_publish.yaml

  Dev->>GH: workflow_dispatch(version?, python_version?)
  GH->>MA: wait-for-approval uses manual_approver (with version)
  note over MA: Creates approval issue with title/body using inputs.version
  MA-->>Approver: Notifies for approval
  Approver-->>MA: Approve / Deny
  MA-->>GH: Outcome (approved or denied)

  alt Approved
    GH->>PP: publish-to-pypi uses poetry_publish (with python_version)
    PP-->>GH: Publish result
  else Denied
    GH-->>Dev: Job stopped (denied)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Ryuk-me

Poem

A whisker-twitch, a version’s name,
I stamp the form in approval’s frame.
From queue to PyPI we lightly hop,
With tidy paths and typed props.
Thump-thump—release! the carrots pop,
Our packages land with a happy plop. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6c09c51 and e3f2425.

📒 Files selected for processing (2)
  • .github/workflows/manual_approver.yaml (2 hunks)
  • .github/workflows/pypi_publish.yml (2 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Kanai2003 Kanai2003 merged commit 965059d into main Aug 25, 2025
3 of 6 checks passed
@Ryuk-me Ryuk-me deleted the fix-ci branch August 25, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants