Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dcs_core/__version__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

__version__ = "0.9.4"
__version__ = "0.9.5"
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "dcs-core"
version = "0.9.4"
version = "0.9.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

Version bump looks good; verify consistency and stale refs.

Aligned with dcs_core.version. Run the script below to confirm no leftover 0.9.4 references and that versions match.


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Compare versions between pyproject.toml and dcs_core/__version__.py
ver_toml=$(sed -n 's/^[[:space:]]*version[[:space:]]*=[[:space:]]*"\(.*\)".*/\1/p' pyproject.toml | head -1)
ver_py=$(sed -n 's/^[[:space:]]*__version__[[:space:]]*=[[:space:]]*"\(.*\)".*/\1/p' dcs_core/__version__.py | head -1)
echo "pyproject.toml version: $ver_toml"
echo "__version__.py version: $ver_py"
test "$ver_toml" = "$ver_py"

# Search for lingering old version strings
old_ver="0.9.4"
echo "Searching for lingering references to $old_ver ..."
rg -nP --hidden --glob '!**/.git/**' "$old_ver" || echo "No references found."

Length of output: 278704


Escape dots when verifying old version references
The current rg -P '0.9.4' treats . as wildcards and flags unrelated entries in poetry.lock and assets. Replace with a fixed‐string search or escape the dots and limit to source files, for example:

# Confirm no lingering 0.9.4 in code (excluding lock and asset files)
rg -nF '0.9.4' --glob '!poetry.lock' --glob '!**/*.svg' .
🤖 Prompt for AI Agents
In pyproject.toml around line 3, the review points out that using a regex search
like 'rg -P '0.9.4'' treats dots as wildcards and returns false positives;
update any verification steps or documentation/scripts to either escape the dots
(e.g. use '0\.9\.4') or use fixed-string search (rg -nF '0.9.4') and restrict
globs to source files (exclude poetry.lock and asset files like SVGs) so only
actual code references are matched.

description = "Open Source Data Quality Monitoring"
license = "Apache-2.0"
authors = [
Expand Down
Loading