Skip to content

Fix formatting glitch that broke page#703

Merged
kmoscoe merged 1 commit into
datacommonsorg:masterfrom
kmoscoe:custom_dc
Apr 30, 2026
Merged

Fix formatting glitch that broke page#703
kmoscoe merged 1 commit into
datacommonsorg:masterfrom
kmoscoe:custom_dc

Conversation

@kmoscoe
Copy link
Copy Markdown
Contributor

@kmoscoe kmoscoe commented Apr 30, 2026

No description provided.

@kmoscoe kmoscoe requested a review from keyurva April 30, 2026 07:54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in custom_dc/advanced.md by adding a closing tag to a Docker command block. A review comment correctly identifies a syntax error in the command snippet: a missing line continuation backslash on the line preceding the image name would cause the shell to fail when executing the command.

Comment thread custom_dc/advanced.md
Comment on lines 84 to +85
-e DATA_RUN_MODE=schemaupdate
gcr.io/datcom-ci/datacommons-data:stable
gcr.io/datcom-ci/datacommons-data:stable</pre>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The docker run command is broken because the line preceding the image name is missing a continuation backslash (\). This will cause the shell to attempt to execute the image name as a separate command. Additionally, to ensure the command is correctly parsed as a single block within the

 tag, the backslash should be added to line 84.

Suggested change
-e DATA_RUN_MODE=schemaupdate
gcr.io/datcom-ci/datacommons-data:stable
gcr.io/datcom-ci/datacommons-data:stable</pre>
-e DATA_RUN_MODE=schemaupdate \
gcr.io/datcom-ci/datacommons-data:stable</pre>

@kmoscoe kmoscoe merged commit 23aeadd into datacommonsorg:master Apr 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants