Fix formatting glitch that broke page#703
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in custom_dc/advanced.md by adding a closing tag to a Docker command block. A review comment correctly identifies a syntax error in the command snippet: a missing line continuation backslash on the line preceding the image name would cause the shell to fail when executing the command.
Comment on lines
84
to
+85
| -e DATA_RUN_MODE=schemaupdate | ||
| gcr.io/datcom-ci/datacommons-data:stable | ||
| gcr.io/datcom-ci/datacommons-data:stable</pre> |
Contributor
There was a problem hiding this comment.
The docker run command is broken because the line preceding the image name is missing a continuation backslash (\). This will cause the shell to attempt to execute the image name as a separate command. Additionally, to ensure the command is correctly parsed as a single block within the
tag, the backslash should be added to line 84.Suggested change
-e DATA_RUN_MODE=schemaupdate gcr.io/datcom-ci/datacommons-data:stable gcr.io/datcom-ci/datacommons-data:stable</pre> -e DATA_RUN_MODE=schemaupdate \ gcr.io/datcom-ci/datacommons-data:stable</pre>
keyurva
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.