Skip to content

Update MCP server name configuration and 2 other fixes#704

Merged
kmoscoe merged 10 commits into
datacommonsorg:masterfrom
kmoscoe:custom_dc
May 1, 2026
Merged

Update MCP server name configuration and 2 other fixes#704
kmoscoe merged 10 commits into
datacommonsorg:masterfrom
kmoscoe:custom_dc

Conversation

@kmoscoe
Copy link
Copy Markdown
Contributor

@kmoscoe kmoscoe commented May 1, 2026

This is a follow-up from the previous PR, which changes the Gemini config example to use a different name for the MCP server in all instances. It also makes the following other changes:

  • Adds the --region command which is required in the gcloud run commands
  • Adds gcloud commands for getting Cloud Run environment variables
  • Adds Console and CLI procedures for getting the DB_PASS variable created by Terraform

Staged at http://bullie.svl.corp.google.com:4000

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Data Commons documentation by adding gcloud CLI instructions, requiring the --region flag for Cloud Run commands, fixing markdown link syntax, and parameterizing server names in MCP configurations. Feedback identifies a syntax error in a gcloud flag, a capitalization typo, and the use of invalid comment syntax in JSON examples.

Comment thread custom_dc/deploy_cloud.md Outdated
Comment thread custom_dc/advanced.md Outdated
Comment thread mcp/host_server.md Outdated
Comment thread mcp/host_server.md Outdated
kmoscoe and others added 6 commits May 1, 2026 16:14
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@kmoscoe kmoscoe changed the title Custom dc Update MCP server name configuration and 2 other fixes May 1, 2026
@kmoscoe kmoscoe requested a review from keyurva May 1, 2026 23:23
@kmoscoe kmoscoe merged commit 83196c9 into datacommonsorg:master May 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants