Implement topic resolver and optimize cache loading#1908
Open
keyurva wants to merge 7 commits into
Open
Conversation
…te topic resolver correctly
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new topic resolver for explicit topic tree navigation and enhances the indicator resolver to support recursive topic expansion. Key changes include the implementation of a TopicExpander interface, a read-through cache for Statistical Variable metadata in TopicCacheManager, and parallelized node fetching in the datasource layer to improve performance and avoid database limits. Feedback focuses on optimizing the cache implementation to prevent stampedes, improving recursive slice allocations, and ensuring robust error handling and logging across the new topic expansion logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolver = "topic"option inside the/v2/resolveAPI and a parameter to request expanding topic hierarchies.Verification / Testing Reference
1. Topic Resolver (expand_topics = false)
Returns immediate sub-topic and variable candidates:
2. Topic Resolver (expand_topics = true)
Recursively expands the entire nested hierarchy cache:
3. Embeddings/Indicator Resolver (expand_topics = false)
Performs semantic embeddings search and returns immediate candidates:
4. Embeddings/Indicator Resolver (expand_topics = true)
Performs semantic search and recursively expands matched topic hierarchies: