Pass Databricks config programmatically#1339
Open
jorgengranseth wants to merge 5 commits into
Open
Conversation
Support passing Databricks config programmatically The UnityImporter did not support Application Default Credentials, which the Databricks WorkspaceClient picks up by default, failing the command if both ADC and another method (required by the CLI) were provided. I changed the code to allow ADC to be used, but I think we may want to rearrange the importer a bit more in order to make it possible to override ADC on-demand by passing configuration.
Contributor
|
Thanks for the PR. |
jschoedl
added
the
waiting-for-decision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv run pytest)uv run ruff check --fix && uv run ruff format)README.md updated (if relevant)An approach to #1250 with Databricks as a proof of concept.
UnityImporterdid not support Application Default Credentials, which the DatabricksWorkspaceClientpicks up by default, failing the command if both ADC and another method (required by the CLI) were provided. I changed the code to allow ADC to be used, but it would be better if it were possible to override ADC on-demand with this custom configuration. It is a bit unclear to me whether that is an issue for this repo or databricks-sdk. Ibis seems to handle this fine, usingdatabricks.sqlrather than theWorkspaceClient