build: migrate CI and toolchain to Node 24, update dependencies#39
Open
simonharrer wants to merge 1 commit into
Open
build: migrate CI and toolchain to Node 24, update dependencies#39simonharrer wants to merge 1 commit into
simonharrer wants to merge 1 commit into
Conversation
- Bump GitHub Actions to Node 24 runtimes: checkout@v6, setup-node@v6, docker setup-qemu@v4, setup-buildx@v4, login@v4, build-push@v7, attest-build-provenance@v4 - Use Node 24 in all workflows and the Dockerfile builder stage; drop the 22.20.0 toolcache pin workaround in release.yml - Update all dependencies within semver ranges - Fix DOMPurify XSS advisories via npm override (dompurify ^3.4.8); monaco-editor stays on 0.54 because 0.55 breaks the monaco-yaml worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkout@v6,setup-node@v6,docker/setup-qemu@v4,docker/setup-buildx@v4,docker/login@v4,docker/build-push@v7,actions/attest-build-provenance@v4node:24-slim); removes the22.20.0pin workaround inrelease.yml(it only existed because of a broken npm in the Node 22.22 toolcache)npm auditnow reports 0 vulnerabilities) via an npm override forcingdompurify@^3.4.8Why monaco-editor stays on 0.54
npm auditsuggests monaco-editor 0.55.1 to fix the DOMPurify advisories, but 0.55 breaks the monaco-yaml web worker — the YAML editor loses validation, folding, and links, with repeatedMissing requestHandlerconsole errors (verified by A/B testing 0.54 vs 0.55 locally). The dompurify override fixes the advisories on its own since Vite resolves monaco's ESMdompurifyimport to the overridden version.Not included (breaking major bumps, for a follow-up): eslint 10, vite 8, @vitejs/plugin-react 6, eslint-plugin-react-hooks 7, globals 17, open 11, monaco-editor 0.55.
Verification
bin/, unrelated to this change)npm audit: 0 vulnerabilities