Skip to content

Security: Patch RCE via Terminology Poisoning and Add Auth Guard #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulleo merged 2 commits into from
Mar 16, 2026
Merged

Security: Patch RCE via Terminology Poisoning and Add Auth Guard #960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2c763
security: fix RCE via terminology poisoning and restrict upload access
jackieya Mar 12, 2026
111e64d
refactor: optimize decorator order and fix HTTPException imports per …
jackieya Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/apps/db/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ def check_sql_read(sql: str, ds: CoreDatasource | AssistantOutDsSchema):
write_types = (
exp.Insert, exp.Update, exp.Delete,
exp.Create, exp.Drop, exp.Alter,
exp.Merge, exp.Command
exp.Merge, exp.Command, exp.Copy
)

for stmt in statements:
Expand Down
1 change: 1 addition & 0 deletions backend/apps/terminology/api/terminology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def inner():


@router.post("/uploadExcel", summary=f"{PLACEHOLDER_PREFIX}upload_term")
@require_permissions(permission=SqlbotPermission(role=['ws_admin']))
@system_log(LogConfig(operation_type=OperationType.IMPORT, module=OperationModules.TERMINOLOGY))
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorator order means permission-denied requests won't be captured by @system_log. With the current order, require_permissions(...) runs before system_log(...), so if require_permissions raises (e.g., non-admin), the logging decorator never executes and the attempted import isn't audited. Consider swapping the decorators so @system_log(...) is above @require_permissions(...) (i.e., system_log(require_permissions(upload_excel))).

Suggested change
@require_permissions(permission=SqlbotPermission(role=['ws_admin']))
@system_log(LogConfig(operation_type=OperationType.IMPORT, module=OperationModules.TERMINOLOGY))
@system_log(LogConfig(operation_type=OperationType.IMPORT, module=OperationModules.TERMINOLOGY))
@require_permissions(permission=SqlbotPermission(role=['ws_admin']))

Copilot uses AI. Check for mistakes.
async def upload_excel(trans: Trans, current_user: CurrentUser, file: UploadFile = File(...)):
ALLOWED_EXTENSIONS = {"xlsx", "xls"}
Comment thread
jackieya marked this conversation as resolved.
Expand Down
Loading