fix(model): validate workbench embedding selection

Author: zgqgit

src/backend/bisheng/llm/domain/services/llm.py

@@ -14,7 +14,13 @@
 from bisheng.common.constants.enums.telemetry import ApplicationTypeEnum
 from bisheng.common.dependencies.user_deps import UserPayload
 from bisheng.common.errcode.http_error import NotFoundError, ServerError
-from bisheng.common.errcode.llm import ModelNameRepeatError, ServerAddAllError, ServerAddError, ServerExistError
+from bisheng.common.errcode.llm import (
+    ModelNameRepeatError,
+    ServerAddAllError,
+    ServerAddError,
+    ServerExistError,
+    WorkbenchEmbeddingError,
+)
 from bisheng.common.errcode.llm_tenant import (
     LLMModelNotAccessibleError,
     LLMSystemConfigForbiddenError,
@@ -1339,6 +1345,12 @@ async def update_workbench_llm(
             ``None`` falls back to the admin-scope ContextVar then Root.
         :return:
         """
+        if config_obj.embedding_model is not None:
+            embedding_model_id = _coerce_model_id(config_obj.embedding_model.id)
+            if embedding_model_id is None:
+                raise WorkbenchEmbeddingError()
+            config_obj.embedding_model.id = str(embedding_model_id)
+
         # Delay imports to avoid looping imports
         from bisheng.worker.knowledge.rebuild_knowledge_worker import rebuild_knowledge_celery
 

src/backend/test/llm/test_workbench_update_merge.py

@@ -17,6 +17,7 @@
 
 import pytest
 
+from bisheng.common.errcode.llm import WorkbenchEmbeddingError
 from bisheng.llm.domain.schemas import WorkbenchModelConfig, WSModel
 from bisheng.llm.domain.services.llm import LLMService
 
@@ -73,3 +74,22 @@ async def test_provided_models_replace_normally():
     incoming = WorkbenchModelConfig(models=[WSModel(id="840", name="qwen3.7-max")], embedding_model=None)
     persisted = await _run_and_capture(incoming)
     assert [m["id"] for m in persisted["models"]] == ["840"]
+
+
+@pytest.mark.parametrize("invalid_model_id", ["", "null", "undefined", "0", "-1"])
+@pytest.mark.asyncio
+async def test_invalid_embedding_model_id_returns_business_error(invalid_model_id: str):
+    config = WorkbenchModelConfig(
+        models=[WSModel(id="840", name="qwen3.7-max")],
+        embedding_model=WSModel(id=invalid_model_id),
+    )
+
+    with patch(
+        "bisheng.llm.domain.services.llm.avalidate_system_model_refs",
+        new=AsyncMock(),
+    ) as mock_validate:
+        with pytest.raises(WorkbenchEmbeddingError) as exc_info:
+            await LLMService.update_workbench_llm(1, config, MagicMock(), tenant_id=1)
+
+    assert exc_info.value.code == 10810
+    mock_validate.assert_not_awaited()

src/frontend/platform/src/pages/ModelPage/manage/tabs/WorkbenchModel.tsx

@@ -14,6 +14,7 @@ import { useTranslation } from "react-i18next";
 import { useQuery } from "react-query";
 import { useModel } from "..";
 import { ModelManagement } from "@/pages/BuildPage/bench/ModelManagement";
+import { hasValidWorkbenchEmbeddingModelId } from "./workbenchModelValidation";
 
 export const ModelSelect = ({ required = false, close = false, label, tooltipText = '', value, options, onChange, placeholder = '' }) => {
     const defaultValue = useMemo(() => {
@@ -87,20 +88,8 @@ export default function WorkbenchModel({ onBack }) {
         return '';
     };
 
-    const handleSave = async () => {
+    const submitConfig = async () => {
         const { linsightDefaultModelId, sourceModelId, asrModelId, ttsModelId, chatTitleLlmId, models } = form;
-        const errors = [];
-        if (!models.length) {
-            errors.push('请至少配置一个对话模型');
-        }
-        // Reject blank rows: a model without an id serializes to `{ id: '' }`,
-        // which reaches the client model picker as <SelectItem value="">
-        // (empty string) and crashes the whole page in Radix. Force the admin
-        // to pick a model or remove the empty row before saving.
-        if (models.some((m) => !m.id)) {
-            errors.push('存在未选择模型的对话模型行，请选择模型或删除该行');
-        }
-        if (errors.length) return message({ variant: 'error', description: errors });
         setSaveLoad(true);
         try {
             const data = {
@@ -159,7 +148,26 @@ export default function WorkbenchModel({ onBack }) {
         return lastEmbeddingId !== currentEmbeddingId;
     };
 
-    const handleSaveWithConfirm = () => {
+    const handleSave = () => {
+        const errors = [];
+        if (!form.models.length) {
+            errors.push('请至少配置一个对话模型');
+        }
+        // Reject blank rows: a model without an id serializes to `{ id: '' }`,
+        // which reaches the client model picker as <SelectItem value="">
+        // (empty string) and crashes the whole page in Radix. Force the admin
+        // to pick a model or remove the empty row before saving.
+        if (form.models.some((model) => !model.id)) {
+            errors.push('存在未选择模型的对话模型行，请选择模型或删除该行');
+        }
+        if (!hasValidWorkbenchEmbeddingModelId(form.sourceModelId)) {
+            errors.push(t('model.workVectorModel') + t('bs:required'));
+        }
+        if (errors.length) {
+            message({ variant: 'error', description: errors });
+            return;
+        }
+
         if (checkEmbeddingModified()) {
             bsConfirm({
                 title: t('model.tip'),
@@ -168,12 +176,12 @@ export default function WorkbenchModel({ onBack }) {
                 okTxt: t('model.confirm'),
                 canelTxt: t('model.cancel'),
                 onOk(next) {
-                    handleSave().then(next);
+                    submitConfig().then(next);
                 },
                 onCancel() { }
             });
         } else {
-            handleSave();
+            submitConfig();
         }
     };
 
@@ -308,7 +316,7 @@ export default function WorkbenchModel({ onBack }) {
                 <Button
                     className="px-10"
                     disabled={saveload}
-                    onClick={handleSaveWithConfirm}
+                    onClick={handleSave}
                 >
                     {saveload && <LoadIcon className="mr-2" />}
                     {t('model.save')}

src/frontend/platform/src/pages/ModelPage/manage/tabs/workbenchModelValidation.ts

@@ -0,0 +1,9 @@
+export function hasValidWorkbenchEmbeddingModelId(value: unknown): boolean {
+  if (typeof value === "number") {
+    return Number.isInteger(value) && value > 0;
+  }
+
+  if (typeof value !== "string") return false;
+
+  return /^[1-9]\d*$/.test(value.trim());
+}

src/frontend/platform/src/test/workbenchModelValidation.test.ts

@@ -0,0 +1,16 @@
+import { describe, expect, it } from "vitest";
+
+import { hasValidWorkbenchEmbeddingModelId } from "@/pages/ModelPage/manage/tabs/workbenchModelValidation";
+
+describe("hasValidWorkbenchEmbeddingModelId", () => {
+  it.each([null, undefined, "", "null", "undefined", "0", "-1", 0, -1])(
+    "rejects an empty or invalid model id: %s",
+    (value) => {
+      expect(hasValidWorkbenchEmbeddingModelId(value)).toBe(false);
+    },
+  );
+
+  it.each([1, 42, "1", "42"])("accepts a positive model id: %s", (value) => {
+    expect(hasValidWorkbenchEmbeddingModelId(value)).toBe(true);
+  });
+});