fix(brand): return defaults for runtime config

Author: zgqgit

src/backend/bisheng/brand/domain/services/brand_service.py

@@ -105,7 +105,7 @@ async def get_config(self) -> BrandConfig:
                 saved = BrandConfig.model_validate(json.loads(raw_value))
                 config = self._merge_with_defaults(saved)
             except (json.JSONDecodeError, ValueError) as exc:
-                logger.warning("Invalid brand_config in DB, using defaults: %s", exc)
+                logger.warning("Invalid brand_config in DB, using defaults: {}", exc)
         await self._hydrate_asset_urls(config)
         return config
 
@@ -211,18 +211,7 @@ async def delete_asset(self, category: BrandAssetCategory, relative_path: str) -
         )
 
     async def get_runtime_config(self) -> dict[str, Any]:
-        raw_value = await self.repository.get_value(BRAND_CONFIG_KEY)
-        if not raw_value:
-            return {}
-
-        try:
-            saved = BrandConfig.model_validate(json.loads(raw_value))
-            config = self._merge_with_defaults(saved)
-        except (json.JSONDecodeError, ValueError) as exc:
-            logger.warning("Invalid brand_config in DB, using static defaults for runtime: %s", exc)
-            return {}
-
-        await self._hydrate_asset_urls(config)
+        config = await self.get_config()
         payload_data = config.model_dump(mode="json")
         payload_data.pop("linsightAgentName", None)
         return payload_data

src/backend/test/brand/test_brand_service.py

@@ -0,0 +1,41 @@
+import json
+from types import SimpleNamespace
+from unittest.mock import AsyncMock
+
+from bisheng.brand.domain.services.brand_service import BRAND_CONFIG_KEY, BrandService
+
+
+def build_service(raw_value: str | None) -> tuple[BrandService, AsyncMock]:
+    get_value = AsyncMock(return_value=raw_value)
+    repository = SimpleNamespace(get_value=get_value)
+    return BrandService(repository=repository), get_value
+
+
+async def test_runtime_config_returns_builtin_brand_when_not_configured() -> None:
+    service, get_value = build_service(None)
+
+    config = await service.get_runtime_config()
+
+    assert config["brandName"] == {"zh": "BISHENG", "en": "BISHENG"}
+    assert config["assets"]["favicon"]["url"] == "/assets/bisheng/favicon.ico"
+    assert "linsightAgentName" not in config
+    get_value.assert_awaited_once_with(BRAND_CONFIG_KEY)
+
+
+async def test_runtime_config_falls_back_to_builtin_brand_for_invalid_saved_config() -> None:
+    service, _ = build_service("{invalid json")
+
+    config = await service.get_runtime_config()
+
+    assert config["brandName"] == {"zh": "BISHENG", "en": "BISHENG"}
+    assert config["assets"]["headerLogoLight"]["url"] == "/assets/bisheng/login-logo-small.png"
+
+
+async def test_runtime_config_preserves_saved_brand_and_fills_default_assets() -> None:
+    saved_config = json.dumps({"brandName": {"zh": "定制品牌", "en": "Custom Brand"}})
+    service, _ = build_service(saved_config)
+
+    config = await service.get_runtime_config()
+
+    assert config["brandName"] == {"zh": "定制品牌", "en": "Custom Brand"}
+    assert config["assets"]["favicon"]["url"] == "/assets/bisheng/favicon.ico"