Skip to content

Commit 59c3050

Browse files
committed
[code review] revert unrelated changes (typos, other fixes)
1 parent 65214eb commit 59c3050

File tree

6 files changed

+20
-9
lines changed

6 files changed

+20
-9
lines changed

src/main/java/net/datafaker/idnumbers/HungarianIdNumber.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ private String basePart(BaseProviders faker, LocalDate birthday, PersonIdNumber.
6464

6565
static int getCheckDigit(String basePart) {
6666
char[] numbers = basePart.toCharArray();
67-
int sum = 0;
67+
int summ = 0;
6868
for (int i = 0; i < numbers.length; i++) {
69-
sum += getNumericValue(numbers[i]) * (i + 1);
69+
summ += getNumericValue(numbers[i]) * (i + 1);
7070
}
7171

72-
return sum % 11;
72+
return summ % 11;
7373
}
7474

7575
static int firstDigit(int birthYear, PersonIdNumber.Gender gender) {

src/main/java/net/datafaker/idnumbers/IdNumberGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ default String generateValid(BaseProviders faker) {
2727
String generateInvalid(BaseProviders faker);
2828

2929
/**
30-
* Generates a valid ID number for given country corresponding to given criteria (age range, gender etc.)
30+
* Generates a valid ID number for given country corresponding to given criterias (age range, gender etc.)
3131
*
3232
* @return PersonIdNumber containing a valid combination of ID, Birthday and Gender.
3333
* In countries where ID number doesn't contain gender and/or birthday, the latter values are just random.

src/main/java/net/datafaker/internal/helper/SingletonLocale.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,19 @@ public static SingletonLocale get(@Nullable Locale locale) {
3030
}
3131

3232
public static SingletonLocale getRequired(Locale locale) {
33-
return LOCALE2SINGLETON_LOCALE.computeIfAbsent(locale, (__) -> new SingletonLocale(locale));
33+
SingletonLocale res = LOCALE2SINGLETON_LOCALE.get(locale);
34+
if (res != null) {
35+
return res;
36+
}
37+
synchronized (SingletonLocale.class) {
38+
res = LOCALE2SINGLETON_LOCALE.get(locale);
39+
if (res != null) {
40+
return res;
41+
}
42+
res = new SingletonLocale(locale);
43+
LOCALE2SINGLETON_LOCALE.put(locale, res);
44+
return res;
45+
}
3446
}
3547

3648
public Locale getLocale() {

src/main/java/net/datafaker/providers/base/Barcode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ private long ean(int length) {
5555
while (number > 0) {
5656
i++;
5757
if (i % 2 == 1) {
58-
odd += (int) (number % 10);
58+
odd += number % 10;
5959
} else {
60-
even += (int) (number % 10);
60+
even += number % 10;
6161
}
6262

6363
number /= 10;

src/main/java/net/datafaker/providers/base/Lorem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public String sentence(int wordCount) {
113113
public String sentence(int wordCount, int randomWordsToAdd) {
114114
int numberOfWordsToAdd = randomWordsToAdd == 0 ? 0 : faker.random().nextInt(randomWordsToAdd);
115115
final int totalWordCount = wordCount + numberOfWordsToAdd;
116-
StringBuilder sb = new StringBuilder(wordCount * 9);
116+
StringBuilder sb = new StringBuilder();
117117
if (totalWordCount > 0) {
118118
sb.append(capitalizeWords(word()));
119119
}

src/test/java/net/datafaker/service/FakeValuesServiceTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ void testLocalesChainGetterRu() {
210210
}
211211

212212
@Test
213-
@SuppressWarnings("deprecation")
214213
void testFakerContextSetLocale() {
215214
final FakerContext fakerContext = new FakerContext(new Locale("en"), new RandomService());
216215
fakerContext.setLocale(new Locale("uk"));

0 commit comments

Comments
 (0)