use faker.options() to pick element from list

... instead of re-implementing this method every time.

Author: asolntsev

src/main/java/net/datafaker/providers/base/Finance.java

@@ -134,8 +134,8 @@ public String bic() {
      */
     public String iban() {
         List<String> countryCodes = new ArrayList<>(countryCodeToBasicBankAccountNumberPattern.keySet());
-        String randomCountryCode = countryCodes.get(faker.random().nextInt(countryCodes.size()));
-        return iban(randomCountryCode);
+        String countryCode = faker.options().nextElement(countryCodes);
+        return iban(countryCode);
     }
 
     /**

src/main/java/net/datafaker/providers/base/Nation.java

@@ -1,15 +1,13 @@
 package net.datafaker.providers.base;
 
-import java.nio.charset.Charset;
-import java.nio.charset.StandardCharsets;
 import java.util.Locale;
 
 /**
  * @since 0.8.0
  */
 public class Nation extends AbstractProvider<BaseProviders> {
-
-    private static final Charset UTF8_CHARSET = StandardCharsets.UTF_8;
+    private static final String[] isoLanguages = Locale.getISOLanguages();
+    private static final String[] isoCountries = Locale.getISOCountries();
 
     protected Nation(BaseProviders faker) {
         super(faker);
@@ -32,12 +30,10 @@ public String flag() {
     }
 
     public String isoLanguage() {
-        String[] isoLangs = Locale.getISOLanguages();
-        return isoLangs[faker.random().nextInt(isoLangs.length)];
+        return faker.options().option(isoLanguages);
     }
 
     public String isoCountry() {
-        String[] isoCountries = Locale.getISOCountries();
-        return isoCountries[faker.random().nextInt(isoCountries.length)];
+        return faker.options().option(isoCountries);
     }
 }

src/main/java/net/datafaker/providers/base/Relationship.java

@@ -49,7 +49,7 @@ public String sibling() {
     }
 
     public String any() {
-        Kind kind = faker.options().option(Kind.values());
+        Kind kind = faker.options().option(Kind.class);
         return resolve(kind.expression);
     }
 

src/main/java/net/datafaker/providers/base/Shakespeare.java

@@ -79,7 +79,7 @@ public String romeoAndJulietQuote() {
     }
 
     private String randomElement(String[] values) {
-        return values[faker.random().nextInt(values.length)];
+        return faker.options().option(values);
     }
 
 }

src/main/java/net/datafaker/providers/base/Sip.java

@@ -53,11 +53,11 @@ public int messagingPort() {
      * @return an RTP UDP 5 digit port int, e.g. 40002.
      */
     public int rtpPort() {
-        return portPool[faker.random().nextInt(portPool.length)];
+        return faker.options().option(portPool);
     }
 
     /**
-     * Proviosional code, the various response codes are listed in
+     * Provisional code, the various response codes are listed in
      * <a href="https://en.wikipedia.org/wiki/List_of_SIP_response_codes">https://en.wikipedia.org/wiki/List_of_SIP_response_codes</a>.
      *
      * @return a 3 digit SIP provision response code between 100 and 199 int, e.g. {@code 180}.
@@ -117,7 +117,7 @@ public int globalErrorResponseCode() {
     }
 
     /**
-     * Proviosional phrase, the various response phrases are listed in
+     * Provisional phrase, the various response phrases are listed in
      * <a href="https://en.wikipedia.org/wiki/List_of_SIP_response_codes">https://en.wikipedia.org/wiki/List_of_SIP_response_codes</a>.
      *
      * @return a SIP provisional response phrase String, e.g. {@code Ringing}.