Skip to content

Commit eb179f2

Browse files
authored
Merge pull request #1615 from abudevich/fix-csv-generate
Fix csv generate by limit
2 parents dcaf65c + 76df74e commit eb179f2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/net/datafaker/service/FakeValuesService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ public String csv(String delimiter, char quote, boolean withHeader, int limit, S
563563
}
564564
Schema<String, String> schema = Schema.of(fields);
565565
return CsvTransformer.<String>builder().separator(delimiter).quote(quote).header(withHeader)
566-
.build().generate(schema, limit + 1);
566+
.build().generate(schema, limit);
567567
}
568568

569569
/**

src/test/java/net/datafaker/FakerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,8 @@ void testLimitForCsvExpression(int limit) {
189189
String csvFullExpression = faker.expression("#{csv ';','\"','false','" + limit + "','first_name','#{Name.first_name}','last_name','#{Name.last_name}'}");
190190
String csvShortExpression = faker.expression("#{csv '" + limit + "','first_name','#{Name.first_name}','last_name','#{Name.last_name}'}");
191191

192-
int numberOfLinesFull = 0;
193-
int numberOfLinesShort = 0;
192+
int numberOfLinesFull = csvFullExpression.isEmpty() ? 0 : 1;
193+
int numberOfLinesShort = numberOfLinesFull;
194194
for (int i = 0; i < csvFullExpression.length(); i++) {
195195
if (csvFullExpression.regionMatches(i, System.lineSeparator(), 0, System.lineSeparator().length())) {
196196
numberOfLinesFull++;

0 commit comments

Comments
 (0)