Skip to content

add Hungarian id number generator#1555

Merged
kingthorin merged 1 commit into
datafaker-net:mainfrom
cbxp:feature/hungarian-id-number
May 19, 2025
Merged

add Hungarian id number generator#1555
kingthorin merged 1 commit into
datafaker-net:mainfrom
cbxp:feature/hungarian-id-number

Conversation

@cbxp
Copy link
Copy Markdown
Contributor

@cbxp cbxp commented May 16, 2025

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented May 16, 2025

PR Summary

  • Introduction of a new class
    A new class named HungarianIdNumber has been added to the system. This class functions as a generator for Hungarian personal identification numbers, with the capability to produce both valid and invalid numbers.

  • Modification to service list
    Our service roster for the IdNumberGenerator has been updated to include the recently created HungarianIdNumber.

  • Addition of new pattern recognition
    In order to efficiently process Hungarian ID numbers, we've expanded the pattern recognition capabilities within IdNumberPatterns.java.

  • Creation of new test class
    To verify our HungarianIdNumber class is functioning optimally, we've constructed a dedicated test class, HungarianIdNumberTest.

  • Improvements to existing tests
    We've oversaw and updated IdNumberTest to incorporate comprehensive tests for both valid and invalid Hungarian identification numbers. This ensures our system's robustness in handling these IDs.

@cbxp cbxp force-pushed the feature/hungarian-id-number branch from ea34bbc to 57f5689 Compare May 16, 2025 11:41
@kingthorin
Copy link
Copy Markdown
Collaborator

You seem to have mixed accounts, feel free to reset author if you care.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (0b23383) to head (d0c3c54).
⚠️ Report is 283 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1555      +/-   ##
============================================
- Coverage     92.50%   92.45%   -0.05%     
- Complexity     3296     3309      +13     
============================================
  Files           328      329       +1     
  Lines          6482     6509      +27     
  Branches        630      634       +4     
============================================
+ Hits           5996     6018      +22     
- Misses          336      338       +2     
- Partials        150      153       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/main/java/net/datafaker/idnumbers/HungarianIdNumber.java Outdated
@cbxp cbxp force-pushed the feature/hungarian-id-number branch from 57f5689 to e7cc99a Compare May 16, 2025 14:08
Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I probably should have noticed these two items earlier.

Comment thread src/test/java/net/datafaker/helpers/IdNumberPatterns.java Outdated
Comment thread src/test/java/net/datafaker/idnumbers/HungarianIdNumberTest.java
@cbxp cbxp force-pushed the feature/hungarian-id-number branch from e7cc99a to d0c3c54 Compare May 19, 2025 06:48
@asolntsev asolntsev added this to the 2.4.4 milestone May 19, 2025
@kingthorin kingthorin merged commit 71fd588 into datafaker-net:main May 19, 2025
13 checks passed
@asolntsev asolntsev self-assigned this Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants