Added new food provider - Cheese.#1797
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1797 +/- ##
============================================
- Coverage 92.27% 92.24% -0.04%
- Complexity 3469 3475 +6
============================================
Files 340 341 +1
Lines 6824 6834 +10
Branches 670 670
============================================
+ Hits 6297 6304 +7
- Misses 361 362 +1
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
Could you cleanup the PR removing the unrelated (and I believe already merged) content?
asolntsev
left a comment
asolntsev
left a comment
There was a problem hiding this comment.
Good - except the unrelated changed in this PR.
I am a bit confused of what that "unrelated" could be since the fork was synced just before the push. Supposedly that is about "Emergency" reference in the README.md - removed that. |
| lens: ["500мм/8", "17мм/2.0", "35мм/1.8", "50мм/1.2", "50мм/1.4", "50мм/1.8", "17-85мм/4.0-8.0", "85мм/1.2", "40мм/2.8", "70–300мм/4.5–5.6", "300мм/2.8", "35-350мм/3.5-5.6", "75-300мм/4-5.6", "24мм/1.4", "17–40мм/4", "24–105мм/4", "70–200мм/2.8", "70–200мм/4", "200-400мм/4", "85мм/1.8", "135мм/4", "600мм/4", "800мм/5.6", "18–55мм/3.5–5.6", "55–250мм/4–5.6", "10-24мм/3.5-4.5", "12-24мм/4", "16-85мм/3.5-5.6", "17-55мм/2.8", "18-55мм/3.5-5.6", "18-70мм/3.5-4.5", "18-105мм/3.5-5.6", "18-140мм/3.5-5.6", "18-200мм/3.5-5.6", "18-300мм/3.5-5.6", "18-300мм/3.5-6.3", "55-200мм/4-5.6", "рыбий глаз", "теле", "широкоугольный"] | ||
| genre: ["Абстракция", "Портрет", "Пейзаж", "Техника", "Транспорт", "Авиация", "Поезда", "Корабли", "Автомобили", "Велосипеды", "Армейское", "ВМФ", "Флора", "Фауна", "Спорт", "Улица", "Город", "Деревня", "за городом", "Архитектура", "Интерьер", "Пища", "Свадьба", "Из готового", "Папарацци", "Общественное", "Мода", "Красота", "Ню", "Наука", "Космос", "Воздушное", "Промышленное", "Искусство", "Под водой", "Ночь", "чёрный ключ", "белый ключ", "ЛОМО", "Панорама", "Макро", "Микро", "Нано"] | ||
| imagetag: ["Ч/Б", "стена", "небо", "облака", "трава", "дерево", "улица", "город", "техника", "самобеги", "вагоны", "повозки", "самолёты", "люди", "чай", "кофе", "ресторан", "лес", "луг", "гора", "вода", "река", "солнечно", "облачно", "дождливо", "дождь", "волна", "капля", "девушка", "кирпич", "океан", "море", "речушка", "весна", "пружина", "фестиваль", "празднование", "представление", "танцы", "вселенная", "звёзды", "галактика", "МИР", "МКС", "ракета", "реактивный самолёт", "боец", "истребитель", "певец", "действие", "показ", "театр"] | ||
| photography: |
There was a problem hiding this comment.
All this too
(Maybe this part isn't already merged, but it also isn't related to the PR)
There was a problem hiding this comment.
Oh, thank you for pointing that out. Removed.
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
Just one comment and a few ideas/questions.
Doesn't necessarily need to be for this PR but would brands, rind type or edibility, or wrap/packaging (wax, paper, plastic, etc) be of any benefit?
| public String colour() { | ||
| return resolve("cheese.colour"); |
There was a problem hiding this comment.
Sorry to be a pain but I believe the library tries to stick with US spelling. (I did a quick code search)
Could you make this color? [plus update the data ref, JavaDoc, tests)
(I guess if you really want a colour variant it should be in a en-GB and en-CA localization.
There was a problem hiding this comment.
Ok, no problem. Changed to color.
Sounds interesting. Let me add that in a separate PR. |
4 participants
Added new food provider - Cheese. It provides cheese-related fake data like name, type, texture, milk etc.
Data source:
https://www.cheese.com
https://en.wikipedia.org/wiki/Types_of_cheese