Cheese provider: added producer, rind and packaging data.#1798
Cheese provider: added producer, rind and packaging data.#1798L-Evg wants to merge 8 commits intodatafaker-net:mainfrom
Conversation
PR Summary
|
|
@L-Evg Please fix the JavaDoc: /home/runner/work/datafaker/datafaker/src/main/java/net/datafaker/providers/food/Cheese.java:62: error: unexpected text after parenthesis
06:45:50.703 [ERROR] * {@link #milk(), {@link #rind(), {@link #rindEdibility(), and {@link #packaging ()}. |
asolntsev
left a comment
There was a problem hiding this comment.
Good, except for JavaDoc errors.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
============================================
+ Coverage 92.18% 92.33% +0.15%
- Complexity 3473 3482 +9
============================================
Files 341 341
Lines 6834 6838 +4
Branches 670 670
============================================
+ Hits 6300 6314 +14
+ Misses 364 359 -5
+ Partials 170 165 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed. |
|
As much as I like cheese, do we really need 2500 lines of extra code here? I wasn't planning on providing solutions for everything, people can create a custom provider for that, so what's the use case for this, and why so many? |
"why so many" - a lot of cheese names. a lot of producers in the world. "2500 lines of extra code here" - ok, how many would be enough? |
There's also a lot of cars models in the world. Doesn't mean we need all of them.
I don't know, that depends on your usecase. I just think 1500+ of new data is a bit excessive, especially for cheese. |
Partially my fault. On the previous PR I got thinking about what else might be useful to someone and suggested these three things, maybe I suggested the wrong direction. |
Decreased the producers list. |
Added producer, rind and packaging data to Cheese food provider.
Data sources:
https://www.tasteatlas.com/cheese/product
https://www.wisconsincheese.com/the-cheese-life/article/31/cheese-rinds
https://www.bluecart.com/blog/cheese-packaging-materials