Skip to content

Cheese provider: added producer, rind and packaging data.#1798

Open
L-Evg wants to merge 8 commits intodatafaker-net:mainfrom
L-Evg:feature/Cheese_Provider
Open

Cheese provider: added producer, rind and packaging data.#1798
L-Evg wants to merge 8 commits intodatafaker-net:mainfrom
L-Evg:feature/Cheese_Provider

Conversation

@L-Evg
Copy link
Copy Markdown
Contributor

@L-Evg L-Evg commented Apr 19, 2026

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 19, 2026

PR Summary

  • Improved Documentation
    We've enhanced our documentation to provide more details about various cheese-related data sources.
  • Updated Cheese Class Methods
    We have introduced new methods in the 'Cheese' class, including 'producer,' 'rind', 'rindEdibility', and 'packaging'. These methods will provide more comprehensive information about the cheese.
  • Enhanced Return Object
    The 'wedge' method has been tweaked to include new attributes resulting in a more detailed 'Wedge' object.
  • Expanded Wedge Record
    Our 'Wedge' record now comes with additional parameters: 'producer', 'rind', 'rindEdibility', and 'packaging', for more comprehensive details.
  • Extended Language Support
    We have added translations for 'rind', 'rind_edibility', and 'packaging' properties in our Russian language resource file to extend our language support.
  • Modified Testing Framework
    We have augmented our tests in 'CheeseTest' to validate the new properties and methods for ensuring flawless functionality.

@asolntsev
Copy link
Copy Markdown
Collaborator

asolntsev commented Apr 19, 2026

@L-Evg Please fix the JavaDoc:

/home/runner/work/datafaker/datafaker/src/main/java/net/datafaker/providers/food/Cheese.java:62: error: unexpected text after parenthesis
06:45:50.703 [ERROR]      * {@link #milk(), {@link #rind(), {@link #rindEdibility(), and {@link #packaging ()}.

Copy link
Copy Markdown
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, except for JavaDoc errors.

@asolntsev asolntsev added this to the 2.6.0 milestone Apr 19, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 19, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (4c9b3da) to head (9f4ff94).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1798      +/-   ##
============================================
+ Coverage     92.18%   92.33%   +0.15%     
- Complexity     3473     3482       +9     
============================================
  Files           341      341              
  Lines          6834     6838       +4     
  Branches        670      670              
============================================
+ Hits           6300     6314      +14     
+ Misses          364      359       -5     
+ Partials        170      165       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@L-Evg
Copy link
Copy Markdown
Contributor Author

L-Evg commented Apr 19, 2026

Good, except for JavaDoc errors.

Fixed.

@bodiam
Copy link
Copy Markdown
Contributor

bodiam commented Apr 19, 2026

As much as I like cheese, do we really need 2500 lines of extra code here? I wasn't planning on providing solutions for everything, people can create a custom provider for that, so what's the use case for this, and why so many?

@L-Evg
Copy link
Copy Markdown
Contributor Author

L-Evg commented Apr 19, 2026

As much as I like cheese, do we really need 2500 lines of extra code here? I wasn't planning on providing solutions for everything, people can create a custom provider for that, so what's the use case for this, and why so many?

"why so many" - a lot of cheese names. a lot of producers in the world.

"2500 lines of extra code here" - ok, how many would be enough?

@bodiam
Copy link
Copy Markdown
Contributor

bodiam commented Apr 19, 2026

"why so many" - a lot of cheese names. a lot of producers in the world.

There's also a lot of cars models in the world. Doesn't mean we need all of them.

"2500 lines of extra code here" - ok, how many would be enough?

I don't know, that depends on your usecase. I just think 1500+ of new data is a bit excessive, especially for cheese.

@kingthorin
Copy link
Copy Markdown
Collaborator

As much as I like cheese, do we really need 2500 lines of extra code here? I wasn't planning on providing solutions for everything, people can create a custom provider for that, so what's the use case for this, and why so many?

Partially my fault. On the previous PR I got thinking about what else might be useful to someone and suggested these three things, maybe I suggested the wrong direction.

@L-Evg
Copy link
Copy Markdown
Contributor Author

L-Evg commented Apr 19, 2026

As much as I like cheese, do we really need 2500 lines of extra code here? I wasn't planning on providing solutions for everything, people can create a custom provider for that, so what's the use case for this, and why so many?

"why so many" - a lot of cheese names. a lot of producers in the world.

"2500 lines of extra code here" - ok, how many would be enough?

Decreased the producers list.

@L-Evg L-Evg requested a review from asolntsev April 21, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants