Skip to content

Commit 154df72

Browse files
authored
Revert "fix: Notify k8s of broken pool executors (#324)" (#325)
This reverts commit 7ff89a1.
1 parent 7ff89a1 commit 154df72

5 files changed

Lines changed: 4 additions & 39 deletions

File tree

charts/datafold-manager/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: datafold-manager
33
description: Helm chart for Datafold Operator
44
type: application
5-
version: 0.1.101
5+
version: 0.1.100
66
appVersion: "1.0.0"
77
icon: https://www.datafold.com/logo.png
88

charts/datafold-manager/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ operator:
1818
# Operator image configuration
1919
image:
2020
repository: us-docker.pkg.dev/datadiff-mm/datafold/datafold-operator
21-
tag: "1.1.71"
21+
tag: "1.1.70"
2222
pullPolicy: Always
2323

2424
# Operator deployment configuration

charts/datafold/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: datafold
33
description: Helm chart package to deploy Datafold on kubernetes.
44
type: application
5-
version: 0.10.85
5+
version: 0.10.84
66
appVersion: "1.0.0"
77
icon: https://www.datafold.com/logo.png
88

charts/datafold/charts/worker-temporal/templates/deployment.yaml

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -103,35 +103,14 @@ spec:
103103
- name: TEMPORAL_METRICS_BIND_ADDRESS
104104
value: "0.0.0.0:{{ .Values.metrics.port }}"
105105
{{- end }}
106-
{{- if .Values.health.enabled }}
107-
- name: TEMPORAL_HEALTH_PORT
108-
value: {{ .Values.health.port | quote }}
109-
{{- end }}
110106
{{- with .Values.extraEnv }}
111107
{{- toYaml . | nindent 12 }}
112108
{{- end }}
113-
{{- if or .Values.metrics.enabled .Values.health.enabled }}
109+
{{- if .Values.metrics.enabled }}
114110
ports:
115-
{{- if .Values.metrics.enabled }}
116111
- name: metrics
117112
containerPort: {{ .Values.metrics.port }}
118113
protocol: TCP
119-
{{- end }}
120-
{{- if .Values.health.enabled }}
121-
- name: health
122-
containerPort: {{ .Values.health.port }}
123-
protocol: TCP
124-
{{- end }}
125-
{{- end }}
126-
{{- if .Values.health.enabled }}
127-
livenessProbe:
128-
httpGet:
129-
path: /
130-
port: {{ .Values.health.port }}
131-
initialDelaySeconds: {{ .Values.health.livenessProbe.initialDelaySeconds }}
132-
periodSeconds: {{ .Values.health.livenessProbe.periodSeconds }}
133-
failureThreshold: {{ .Values.health.livenessProbe.failureThreshold }}
134-
timeoutSeconds: {{ .Values.health.livenessProbe.timeoutSeconds }}
135114
{{- end }}
136115
resources:
137116
{{- toYaml .Values.resources | nindent 12 }}

charts/datafold/charts/worker-temporal/values.yaml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -76,20 +76,6 @@ metrics:
7676
enabled: true
7777
port: 9090
7878

79-
health:
80-
# Enables the HTTP liveness probe endpoint (TEMPORAL_HEALTH_PORT).
81-
# When the activity executor becomes broken the endpoint returns 503, which
82-
# triggers K8s to send SIGTERM and schedule a replacement pod immediately.
83-
# The old pod continues draining within terminationGracePeriodSeconds so
84-
# in-flight work on healthy threads can still complete.
85-
enabled: true
86-
port: 8091
87-
livenessProbe:
88-
initialDelaySeconds: 30
89-
periodSeconds: 15
90-
failureThreshold: 4
91-
timeoutSeconds: 5
92-
9379
extraEnv: []
9480

9581
volumes: []

0 commit comments

Comments
 (0)