feat: Add Oracle table provider with rust-oracle driver#521
feat: Add Oracle table provider with rust-oracle driver#521banickn wants to merge 2 commits intodatafusion-contrib:mainfrom
Conversation
22019fb to
2c1b888
Compare
Implement Oracle support using rust-oracle (ODPI-C) and bb8 connection pooling. Includes comprehensive type mappings (NUMBER, DATE, TIMESTAMP, CLOB, BLOB, RAW), schema inference, and 12 integration tests. Tested against Oracle Database 23c Free. Note: This is my first contribution to the project. Feedback welcome! :)
f653c95 to
84972c8
Compare
|
@banickn thank you! We actually already have a Oracle table provider in Spice (https://github.com/spiceai/spiceai/tree/trunk/crates/data_components/src/oracle). You may want to compare the implementations, and we'd be happy to contribute this too. |
|
I wasn't aware of the spice.ai oracle table provider. Just for clarification, your suggestion is that I should implement the improvements from spice.ai to this PR? |
|
@lukekim Thanks for pointing out the implementation. That made it a lot easier. Here's a summary of the changes from my first commit. Optimized type mappings, custom dialect for the SQL generation, chunked execution and automated session timezone handling. |
Implement Oracle support using rust-oracle (ODPI-C) and bb8 connection pooling. Includes comprehensive type mappings (NUMBER, DATE, TIMESTAMP, CLOB, BLOB, RAW), schema inference, and 12 integration tests.
Tested against Oracle Database 23c Free.
Note: This is my first contribution to the project. Feedback welcome! :)