fix: Align SqlTable::supports_filters_pushdown with scan_to_sql by using Unparser#637
Merged
sgrebnov merged 2 commits intospiceai-52from Apr 29, 2026
Merged
Conversation
Jeadie
approved these changes
Apr 29, 2026
phillipleblanc
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SqlTable::supports_filters_pushdown()usedexpr::to_sql_with_engine()to check filter pushdown capability, whilescan_to_sql()usedUnparser::expr_to_sql()for actual SQL generation. The custom converter has a narrowmatchwith a_ => Errcatch-all that rejects valid expressions likeCASE WHEN,IS NULL, andIS NOT NULL— even though the Unparser handles them correctly.This mismatch causes filters to be incorrectly reported as
Unsupported, preventing pushdown of expressions thatscan_to_sql()can convert to SQL.Changes:
supports_filters_pushdown()to useUnparser::expr_to_sql()with the table's dialect, matching the converter used byscan_to_sql()Exists,InSubquery,ScalarSubquery) andOuterReferenceColumnbefore the Unparser check, since the Unparser can convert these to SQL text but they must not be pushed intoTableScan.full_filters— subqueries reference tables potentially in other databases, and outer references belong to an enclosing query the table provider cannot resolve