fix(test): fix flaky ingestionV3/run_history_v2.js Cypress test (#16913)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: pedro93

smoke-test/tests/cypress/cypress/e2e/ingestionV3/run_history_v2.js

@@ -11,75 +11,98 @@ import {
   goToIngestionPage,
 } from "./utils";
 
+const testId = Math.floor(Math.random() * 100000);
+
 describe("run history tab in manage data sources", () => {
+  const createdSources = [];
+
   beforeEach(() => {
     setIngestionRedesignFlags(true);
     cy.login();
     goToIngestionPage();
   });
 
-  Cypress.on("uncaught:exception", (err, runnable) => false);
+  afterEach(() => {
+    // Guarantee cleanup even if a test fails mid-way
+    if (createdSources.length > 0) {
+      // Use goToIngestionPage() rather than navigateToTab("Sources") so that
+      // cleanup always starts from a known page state. Tests that navigate to
+      // the Run History tab leave the Sources tab out of view, causing
+      // navigateToTab to time out waiting for the tab element.
+      goToIngestionPage();
+      createdSources.forEach((name) => {
+        deleteIngestionSource(name);
+      });
+      createdSources.length = 0;
+    }
+  });
+
+  Cypress.on("uncaught:exception", (err) => {
+    if (err.message.includes("ResizeObserver")) return false;
+    // Suppress null focus errors from the app (pre-existing React bug where
+    // .focus() is called on an unmounted element) to prevent flaky test aborts.
+    if (
+      err.message.includes("Cannot read properties of null (reading 'focus')")
+    )
+      return false;
+    return true;
+  });
 
   it("navigate to run history tab from last run column of sources tab", () => {
-    const sourceName = "test ingestion source history";
+    const sourceName = `test ingestion source history ${testId}`;
+    createdSources.push(sourceName);
     createAndRunIngestionSource(sourceName);
-    cy.wait(2000);
-    cy.contains("td", sourceName)
+    cy.contains("td", sourceName, { timeout: 10000 })
       .siblings("td")
       .find('[data-testid="ingestion-source-last-run"]')
       .click();
     shouldNavigateToRunHistoryTab();
-    navigateToTab("Sources");
-    deleteIngestionSource(sourceName);
   });
 
   it("navigate to run history tab from View run history option in dropdown of sources", () => {
-    const sourceName = "ingestion source history";
+    const sourceName = `ingestion source history ${testId}`;
+    createdSources.push(sourceName);
     createAndRunIngestionSource(sourceName);
-    cy.wait(2000);
-    cy.contains("td", sourceName)
+    cy.contains("td", sourceName, { timeout: 10000 })
       .siblings("td")
       .find('[data-testid="ingestion-more-options"]')
       .click();
     cy.get("body .ant-dropdown-menu").contains("View Run History").click();
     shouldNavigateToRunHistoryTab();
-    navigateToTab("Sources");
-    deleteIngestionSource(sourceName);
   });
 
   it("view past executions in run history tab", () => {
-    const sourceName = "source for past executions";
+    const sourceName = `source for past executions ${testId}`;
+    createdSources.push(sourceName);
     createAndRunIngestionSource(sourceName);
-    cy.wait(2000);
     navigateToTab("RunHistory");
     cy.get('[data-testid="executions-table"]').within(() => {
-      cy.contains('[data-testid="ingestion-source-name"]', sourceName).should(
-        "be.visible",
-      );
+      cy.contains('[data-testid="ingestion-source-name"]', sourceName, {
+        timeout: 10000,
+      }).should("be.visible");
     });
-    navigateToTab("Sources");
-    deleteIngestionSource(sourceName);
   });
 
   it("navigate to sources tab from source name in run history tab", () => {
-    const sourceName = "source for tab navigation";
+    const sourceName = `source for tab navigation ${testId}`;
+    createdSources.push(sourceName);
     createAndRunIngestionSource(sourceName);
-    cy.wait(2000);
     navigateToTab("RunHistory");
     cy.get('[data-testid="executions-table"]').within(() => {
-      cy.contains('[data-testid="ingestion-source-name"]', sourceName)
+      cy.contains('[data-testid="ingestion-source-name"]', sourceName, {
+        timeout: 10000,
+      })
         .should("be.visible")
         .first()
         .click({ force: true });
     });
     shouldNavigateToSourcesTab();
-    cy.wait(2000);
-    deleteIngestionSource(sourceName);
   });
 
   it("filter execution requests by source name", () => {
-    const sourceName1 = "Source1";
-    const sourceName2 = "Source2";
+    const sourceName1 = `Source1 ${testId}`;
+    const sourceName2 = `Source2 ${testId}`;
+    createdSources.push(sourceName1, sourceName2);
 
     createIngestionSource(sourceName1);
     createIngestionSource(sourceName2);
@@ -91,9 +114,5 @@ describe("run history tab in manage data sources", () => {
       cy.contains("td", sourceName1).should("be.visible");
       cy.contains("td", sourceName2).should("not.exist");
     });
-
-    navigateToTab("Sources");
-    deleteIngestionSource(sourceName1);
-    deleteIngestionSource(sourceName2);
   });
 });

smoke-test/tests/cypress/cypress/e2e/ingestionV3/utils.js

@@ -13,6 +13,20 @@ export const setIngestionRedesignFlags = (isOn) => {
         res.body.data.appConfig.featureFlags.showNavBarRedesign = isOn;
       });
     }
+    if (isOn && hasOperationName(req, "batchGetStepStates")) {
+      // Override the response to mark all requested step IDs as already seen,
+      // preventing education modals (e.g. CreateSourceEducationModal) from
+      // appearing during ingestion tests. These tests don't exercise the
+      // onboarding flow.
+      const ids = req.body?.variables?.input?.ids || [];
+      req.reply((res) => {
+        res.body.data = {
+          batchGetStepStates: {
+            results: ids.map((id) => ({ id, properties: [] })),
+          },
+        };
+      });
+    }
   });
 };
 
@@ -24,6 +38,8 @@ const clickIfTestIdPresent = (dataTestId) => {
   cy.get("body", { timeout: 2000 }).then(($body) => {
     if ($body.find(`[data-testid="${dataTestId}"]`).length) {
       cy.get(`[data-testid="${dataTestId}"]`).click();
+      // Wait for the element (and its modal) to fully close before proceeding
+      cy.get(`[data-testid="${dataTestId}"]`).should("not.exist");
     }
   });
 };
@@ -178,7 +194,61 @@ export const updateIngestionSource = (
   cy.waitTextVisible("Successfully updated ingestion source!");
 };
 
+// Cancel any running execution for an ingestion source before deleting it.
+// Without this, the executor keeps processing the run after the source is
+// deleted, consuming memory and causing OOM crashes when runs pile up.
+const cancelRunningExecution = (sourceName) => {
+  cy.request({
+    method: "POST",
+    url: "/api/v2/graphql",
+    body: {
+      query: `query listIngestionSources($input: ListIngestionSourcesInput!) {
+        listIngestionSources(input: $input) {
+          ingestionSources {
+            urn
+            name
+            executions(start: 0, count: 1) {
+              executionRequests {
+                urn
+                result { status }
+              }
+            }
+          }
+        }
+      }`,
+      variables: { input: { start: 0, count: 100, query: sourceName } },
+    },
+    failOnStatusCode: false,
+  }).then((resp) => {
+    if (resp.status !== 200 || !resp.body?.data) return;
+    const sources = resp.body.data.listIngestionSources?.ingestionSources || [];
+    const source = sources.find((s) => s.name === sourceName);
+    if (!source) return;
+    const lastExec = source.executions?.executionRequests?.[0];
+    if (!lastExec) return;
+    const status = lastExec.result?.status;
+    if (status && status !== "RUNNING" && status !== "PENDING") return;
+    cy.request({
+      method: "POST",
+      url: "/api/v2/graphql",
+      body: {
+        query: `mutation cancelIngestionExecutionRequest($input: CancelIngestionExecutionRequestInput!) {
+          cancelIngestionExecutionRequest(input: $input)
+        }`,
+        variables: {
+          input: {
+            ingestionSourceUrn: source.urn,
+            executionRequestUrn: lastExec.urn,
+          },
+        },
+      },
+      failOnStatusCode: false,
+    });
+  });
+};
+
 export const deleteIngestionSource = (sourceName) => {
+  cancelRunningExecution(sourceName);
   cy.contains("td", sourceName)
     .siblings("td")
     .find('[data-testid="ingestion-more-options"]')
@@ -196,7 +266,6 @@ export const createAndRunIngestionSource = (sourceName) => {
 
   // Wait for the source selection modal to appear and any loading to finish
   // Multi-step builder uses "Search..." while old builder uses "Search data sources..."
-  cy.wait(1000); // Wait for modal animations to complete
   cy.get('[placeholder="Search..."], [placeholder="Search data sources..."]', {
     timeout: 10000,
   })