feat(ui): migrate colors to semantic tokens in domainV2 and glossaryV2 folders by purnimagarg1 · Pull Request #16875 · datahub-project/datahub

purnimagarg1 · 2026-04-01T12:07:41Z

Linear ticket:
https://linear.app/acryl-data/issue/CAT-1660/update-colors-to-semantic-tokens-in-glossary-and-domains-folders

github-actions · 2026-04-01T12:07:53Z

Linear: CAT-1678

alwaysmeticulous · 2026-04-01T12:13:18Z

✅ Meticulous spotted visual differences in 111 of 1446 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

_{Last updated for commit 4ec9d3c address comments, update tokens. This comment will update as new commits are pushed.}

codecov · 2026-04-01T12:19:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codecov · 2026-04-01T12:43:31Z

Bundle Report

Changes will increase total bundle size by 1.46kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	22.73MB	1.46kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	1.46kB	12.48MB	0.01%

Files in assets/index-*.js:

./src/conf/theme/colorThemes/dark.ts → Total Size: 9.5kB
./src/app/domainV2/DomainSearchResultItem.tsx → Total Size: 1.78kB
./src/app/domainV2/nestedDomains/RootDomains.tsx → Total Size: 1.84kB
./src/app/glossaryV2/GlossaryBrowser/NodeItem.tsx → Total Size: 7.44kB
./src/app/glossaryV2/GlossaryBrowser/TermItem.tsx → Total Size: 3.05kB
./src/app/glossaryV2/colorUtils.ts → Total Size: 1.25kB
./src/app/domainV2/DomainsList.tsx → Total Size: 5.6kB
./src/app/domainV2/EmptyDomainDescription.tsx → Total Size: 1.96kB
./src/app/domainV2/nestedDomains/domainNavigator/DomainNode.tsx → Total Size: 6.6kB
./src/app/glossaryV2/BusinessGlossaryPage.tsx → Total Size: 3.5kB
./src/app/glossaryV2/GlossaryEntitiesList.tsx → Total Size: 2.26kB
./src/conf/theme/colorThemes/light.ts → Total Size: 9.43kB
./src/app/glossaryV2/GlossarySearch.tsx → Total Size: 3.39kB
./src/app/domainV2/EmptyDomainsSection.tsx → Total Size: 1.72kB
./src/app/domainV2/nestedDomains/domainNavigator/DomainNavigator.tsx → Total Size: 1.36kB
./src/app/domainV2/DomainSearch.tsx → Total Size: 2.84kB
./src/app/domainV2/DomainAutocompleteOptions.tsx → Total Size: 1.26kB
./src/app/domainV2/DomainItemMenu.tsx → Total Size: 1.6kB

v-tarasevich-blitz-brain

Great job!
Just a few suggestions that could be handled in the follow-ups. Nothing blocking

v-tarasevich-blitz-brain · 2026-04-10T07:09:33Z

                    style={{
                        fontSize: 12,
-                        color: '#BFBFBF',
+                        color: theme.colors.textDisabled,


v-tarasevich-blitz-brain · 2026-04-10T07:17:13Z

        height: 15px;
        width: 15px;
-        color: ${ANTD_GRAY[8]};
+        color: ${(props) => props.theme.colors.textSecondary};


I think we can use just icon

v-tarasevich-blitz-brain · 2026-04-10T07:20:53Z


 const IconContainer = styled.span`
-    color: ${ANTD_GRAY[7]};
+    color: ${(props) => props.theme.colors.textTertiary};


can we use just icon here?

v-tarasevich-blitz-brain · 2026-04-10T07:21:37Z


 const ResultsWrapper = styled.div`
-    background-color: white;
+    background-color: ${(props) => props.theme.colors.bgSurface};


i think it's better to use just bg

Screencast.From.2026-04-10.10-19-45.mp4

v-tarasevich-blitz-brain · 2026-04-10T07:25:43Z

                    style={{
                        fontSize: 12,
-                        color: '#BFBFBF',
+                        color: theme.colors.textDisabled,


just icon

v-tarasevich-blitz-brain · 2026-04-10T07:26:22Z


 const IconContainer = styled.span`
-    color: ${ANTD_GRAY[7]};
+    color: ${(props) => props.theme.colors.textTertiary};


v-tarasevich-blitz-brain · 2026-04-10T07:27:47Z


 const ResultsWrapper = styled.div`
-    background-color: white;
+    background-color: ${(props) => props.theme.colors.bgSurface};


let's use bg

…2 folders (#16875)

github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Apr 1, 2026

github-actions Bot deployed to datahub-project-web-react (Preview) April 1, 2026 12:12 View deployment

vercel Bot deployed to Preview April 1, 2026 12:19 View deployment

Base automatically changed from pg--cat-1551-update-components-semantic-tokens to master April 1, 2026 13:21

maggiehays added the needs-review Label for PRs that need review from a maintainer. label Apr 1, 2026

github-actions Bot deployed to datahub-project-web-react (Preview) April 6, 2026 10:22 View deployment

vercel Bot deployed to Preview April 6, 2026 10:34 View deployment

purnimagarg1 added 3 commits April 7, 2026 19:04

migrate colors to semantic tokens in domainV2 folder

8022bad

update colors to semantic tokens in glossaryV2 folder

f6ac3f1

update remaining colors in glossaryV2 folder

38d5aee

purnimagarg1 force-pushed the pg--cat-1660-semantic-tokens-domains-glossary branch from b9cbf2e to 38d5aee Compare April 7, 2026 13:36

github-actions Bot deployed to datahub-project-web-react (Preview) April 7, 2026 13:41 View deployment

vercel Bot deployed to Preview April 7, 2026 13:50 View deployment

purnimagarg1 changed the title ~~feat(ui): migrate colors to semantic tokens in domainV2 and glossaryV2 folder~~ feat(ui): migrate colors to semantic tokens in domainV2 and glossaryV2 folders Apr 9, 2026

v-tarasevich-blitz-brain approved these changes Apr 10, 2026

View reviewed changes

maggiehays added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Apr 10, 2026

Merge branch 'master' into pg--cat-1660-semantic-tokens-domains-glossary

a236655

github-actions Bot deployed to datahub-project-web-react (Preview) April 10, 2026 13:34 View deployment

vercel Bot deployed to Preview April 10, 2026 13:44 View deployment

Merge branch 'master' into pg--cat-1660-semantic-tokens-domains-glossary

f963b8b

github-actions Bot deployed to datahub-project-web-react (Preview) April 10, 2026 14:14 View deployment

vercel Bot deployed to Preview April 10, 2026 14:24 View deployment

address comments, update tokens

4ec9d3c

github-actions Bot deployed to datahub-project-web-react (Preview) April 13, 2026 11:09 View deployment

vercel Bot deployed to Preview April 13, 2026 11:19 View deployment

purnimagarg1 merged commit 2d5d0ee into master Apr 13, 2026
44 checks passed

purnimagarg1 deleted the pg--cat-1660-semantic-tokens-domains-glossary branch April 13, 2026 11:51

alokr-dhub pushed a commit that referenced this pull request Apr 23, 2026

feat(ui): migrate colors to semantic tokens in domainV2 and glossaryV…

1725536

…2 folders (#16875)

Conversation

purnimagarg1 commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

alwaysmeticulous Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

v-tarasevich-blitz-brain left a comment

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

v-tarasevich-blitz-brain Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alwaysmeticulous Bot commented Apr 1, 2026 •

edited

Loading

codecov Bot commented Apr 1, 2026 •

edited

Loading

codecov Bot commented Apr 1, 2026 •

edited

Loading