Skip to content

feat(ui): update colors to semantic tokens in home and settings folders #16877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purnimagarg1 merged 11 commits into from
Apr 13, 2026
Merged

feat(ui): update colors to semantic tokens in home and settings folders #16877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2979f26
update colors to semantic tokens in homeV3 folder
purnimagarg1 Apr 1, 2026
d8170d3
Merge branch 'master' into pg--cat-1661-update-tokens-home-settings
purnimagarg1 Apr 6, 2026
9ac9c54
update colors to semantic tokens in homeV2 folder
purnimagarg1 Apr 6, 2026
f58f662
update colors to semantic tokens in settingsV2 folder
purnimagarg1 Apr 6, 2026
6c31453
Merge branch 'master' into pg--cat-1661-update-tokens-home-settings
purnimagarg1 Apr 6, 2026
41554dd
fix tests
purnimagarg1 Apr 6, 2026
6fbd00f
fix issues found via meticulous
purnimagarg1 Apr 7, 2026
f628db3
fix more issues
purnimagarg1 Apr 7, 2026
26985dc
Merge branch 'master' into pg--cat-1661-update-tokens-home-settings
purnimagarg1 Apr 10, 2026
b6bb67f
Merge branch 'master' into pg--cat-1661-update-tokens-home-settings
purnimagarg1 Apr 13, 2026
8bd57ea
Merge branch 'master' into pg--cat-1661-update-tokens-home-settings
purnimagarg1 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions datahub-web-react/src/app/homeV2/action/announcement/Announcement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { Editor } from '@components';
import React from 'react';
import styled from 'styled-components/macro';

import { ANTD_GRAY } from '@app/entityV2/shared/constants';
import { toRelativeTimeString } from '@app/shared/time/timeUtils';

import { Post } from '@types';
Expand Down Expand Up @@ -36,7 +35,7 @@ const Title = styled.div`

const Time = styled.div`
font-size: 12px;
color: ${ANTD_GRAY[7]};
color: ${(props) => props.theme.colors.textTertiary};
`;

type Props = {
Expand Down
15 changes: 7 additions & 8 deletions datahub-web-react/src/app/homeV2/action/announcement/Announcements.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@ import styled from 'styled-components';

import analytics, { EventType, HomePageModule } from '@app/analytics';
import { useUserContext } from '@app/context/useUserContext';
import { ANTD_GRAY } from '@app/entity/shared/constants';
import { Announcement } from '@app/homeV2/action/announcement/Announcement';
import { useGetUnseenAnnouncements } from '@app/homeV2/action/announcement/useGetUnseenAnnouncements';
import AnnouncementsSkeleton from '@app/homeV2/content/tabs/announcements/AnnouncementsSkeleton';
import { useUpdateLastViewedAnnouncementTime } from '@app/homeV2/shared/updateLastViewedAnnouncementTime';
import OnboardingContext from '@app/onboarding/OnboardingContext';

const Card = styled.div`
border: 1px solid ${ANTD_GRAY[4]};
border: 1px solid ${(props) => props.theme.colors.bgSurface};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use border* colors

border-radius: 11px;
background-color: #ffffff;
background-color: ${(props) => props.theme.colors.bg};
overflow: hidden;
padding: 16px 20px 8px 20px;
width: 380px;
Expand All @@ -31,20 +30,20 @@ const Header = styled.div`
const Title = styled.div`
font-weight: 600;
font-size: 14px;
color: #434863;
color: ${(props) => props.theme.colors.text};
display: flex;
align-items: center;
justify-content: start;
`;

const Icon = styled(NotificationOutlined)`
margin-right: 8px;
color: #3cb47a;
color: ${(props) => props.theme.colors.textSuccess};
font-size: 16px;
`;

const StyledCloseOutlined = styled(CloseOutlined)`
color: ${ANTD_GRAY[8]};
color: ${(props) => props.theme.colors.textSecondary};
font-size: 12px;
`;

Expand All @@ -55,11 +54,11 @@ const StyledCarousel = styled(Carousel)`
overflow: hidden;

> .slick-dots li button {
background-color: #d9d9d9;
background-color: ${(props) => props.theme.colors.border};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have some more suitable button* token?

}

> .slick-dots li.slick-active button {
background-color: #5c3fd1;
background-color: ${(props) => props.theme.colors.buttonFillBrand};
}
`;

Expand Down
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/homeV2/content/HorizontalListSkeletons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const SectionHeader = styled.div`
.ant-skeleton-button {
height: 100%;
border-radius: 12px;
background-color: #f8f9fa;
background-color: ${(props) => props.theme.colors.bgSurface};
}
`;

Expand Down
14 changes: 6 additions & 8 deletions datahub-web-react/src/app/homeV2/content/recent/EntityCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import React from 'react';
import { Link } from 'react-router-dom';
import styled from 'styled-components';

import { ANTD_GRAY } from '@app/entity/shared/constants';
import { GenericEntityProperties } from '@app/entity/shared/types';
import { SEARCH_COLORS } from '@app/entityV2/shared/constants';
import { getDisplayedEntityType } from '@app/entityV2/shared/containers/profile/header/utils';
import { HoverEntityTooltip } from '@app/recommendations/renderer/component/HoverEntityTooltip';
import PlatformIcon from '@app/sharedV2/icons/PlatformIcon';
Expand All @@ -16,21 +14,21 @@ const Container = styled.div`
display: flex;
flex-direction: row;
padding: 10px 12px 10px 12px;
background-color: #ffffff;
background-color: ${(props) => props.theme.colors.bg};
border-radius: 10px;
min-width: 200px;
max-width: 260px;
border: 1.5px solid #0000001a;
border: 1.5px solid ${(props) => props.theme.colors.border};
gap: 12px;

:hover {
border: 1.5px solid ${SEARCH_COLORS.LINK_BLUE};
border: 1.5px solid ${(props) => props.theme.colors.hyperlinks};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderBrand

}
`;

const Name = styled.div`
font-size: 14px;
color: #565657;
color: ${(props) => props.theme.colors.textSecondary};
margin-bottom: 4px;
font-weight: 500;
overflow: hidden;
Expand All @@ -46,15 +44,15 @@ const Context = styled.div`

const SubHeader = styled.div`
font-size: 14px;
color: ${ANTD_GRAY[5]};
color: ${(props) => props.theme.colors.border};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try with textTertiary

margin-top: 4px;
overflow: hidden;
text-overflow: ellipsis;
`;

const Type = styled.div`
font-size: 14px;
color: ${ANTD_GRAY[7]};
color: ${(props) => props.theme.colors.textTertiary};
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
Expand Down
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/homeV2/content/recent/EntityCardList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const Container = styled.div`
`;

const Title = styled.div`
color: #403d5c;
color: ${(props) => props.theme.colors.text};
margin: 0px;
font-size: 18px;
font-weight: 600;
Expand Down
6 changes: 3 additions & 3 deletions datahub-web-react/src/app/homeV2/content/recent/RecentActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,22 @@ const Container = styled.div<{ $isShowNavBarRedesign?: boolean }>`
align-items: start;
justify-content: start;
padding: ${(props) => (props.$isShowNavBarRedesign ? '16px 20px' : '16px 24px 24px 24px')};
background-color: #fff;
background-color: ${(props) => props.theme.colors.bg};

${(props) =>
!props.$isShowNavBarRedesign &&
`
margin-top: 24px;
overflow: hidden;
border-radius: 10px;
border: 1.5px solid #ecf2f9;
border: 1.5px solid ${props.theme.colors.border};
`}

${(props) =>
props.$isShowNavBarRedesign &&
`
border-radius: ${props.theme.styles['border-radius-navbar-redesign']};
box-shadow: ${props.theme.styles['box-shadow-navbar-redesign']};
box-shadow: ${props.theme.colors.shadowSm};
margin: 0 5px;
`}
`;
Expand Down
7 changes: 3 additions & 4 deletions datahub-web-react/src/app/homeV2/content/tabs/announcements/AnnouncementCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ import { Editor } from '@components';
import React from 'react';
import styled from 'styled-components/macro';

import { ANTD_GRAY } from '@app/entity/shared/constants';
import { toRelativeTimeString } from '@app/shared/time/timeUtils';

import { Post } from '@types';

const Card = styled.div`
border: 1px solid ${ANTD_GRAY[4]};
border: 1px solid ${(props) => props.theme.colors.bgHover};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use border?

border-radius: 8px;
background-color: #ffffff;
background-color: ${(props) => props.theme.colors.bg};
overflow: auto;
`;

Expand All @@ -34,7 +33,7 @@ const Title = styled.div`

const Time = styled.div`
font-size: 12px;
color: ${ANTD_GRAY[7]};
color: ${(props) => props.theme.colors.textTertiary};
`;

type Props = {
Expand Down
6 changes: 2 additions & 4 deletions datahub-web-react/src/app/homeV2/content/tabs/discovery/sections/Section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@ import { Tooltip } from '@components';
import React from 'react';
import styled from 'styled-components/macro';

import { ANTD_GRAY } from '@app/entity/shared/constants';

const Header = styled.div`
display: flex;
justify-content: space-between;
align-items: center;
`;

const Title = styled.div`
color: #403d5c;
color: ${(props) => props.theme.colors.text};
margin: 0px;
font-size: 18px;
font-weight: 600;
Expand All @@ -29,7 +27,7 @@ const Content = styled.div`
`;

const Action = styled.div`
color: ${ANTD_GRAY[8]};
color: ${(props) => props.theme.colors.textSecondary};
font-size: 12px;
font-weight: 700;
:hover {
Expand Down
15 changes: 7 additions & 8 deletions ...web-react/src/app/homeV2/content/tabs/discovery/sections/dataProducts/DataProductCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,23 @@ import React from 'react';
import { Link } from 'react-router-dom';
import styled from 'styled-components/macro';

import { ANTD_GRAY } from '@app/entity/shared/constants';
import { SEARCH_COLORS } from '@app/entityV2/shared/constants';
import { DomainColoredIcon } from '@app/entityV2/shared/links/DomainColoredIcon';
import { HoverEntityTooltip } from '@app/recommendations/renderer/component/HoverEntityTooltip';
import { useEntityRegistry } from '@app/useEntityRegistry';
import { colors } from '@src/alchemy-components';
import { useShowNavBarRedesign } from '@src/app/useShowNavBarRedesign';

import { DataProduct, Domain, EntityType } from '@types';

const Card = styled(Link)<{ $isShowNavBarRedesign?: boolean }>`
border-radius: ${(props) => (props.$isShowNavBarRedesign ? '8px' : '10px')};
background-color: #ffffff;
background-color: ${(props) => props.theme.colors.bg};
padding: 10px 16px;
border: ${(props) => (props.$isShowNavBarRedesign ? `1px solid ${colors.gray[100]}` : '2px solid transparent')};
border: ${(props) =>
props.$isShowNavBarRedesign ? `1px solid ${props.theme.colors.border}` : '2px solid transparent'};

:hover {
border: ${(props) => (props.$isShowNavBarRedesign ? '1px' : '2px')} solid ${SEARCH_COLORS.LINK_BLUE};
border: ${(props) => (props.$isShowNavBarRedesign ? '1px' : '2px')} solid
${(props) => props.theme.colors.hyperlinks};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderHover

}

display: flex;
Expand All @@ -36,7 +35,7 @@ const Text = styled.div`

const Name = styled.div`
font-size: 16px;
color: ${ANTD_GRAY[9]};
color: ${(props) => props.theme.colors.text};
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand All @@ -53,7 +52,7 @@ const Section = styled.div`
const SectionName = styled.div`
font-size: 14px;
margin-left: 10px;
color: ${ANTD_GRAY[7]};
color: ${(props) => props.theme.colors.textTertiary};
overflow: hidden;
text-overflow: ellipsis;
`;
Expand Down
15 changes: 7 additions & 8 deletions datahub-web-react/src/app/homeV2/content/tabs/discovery/sections/domains/DomainCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,24 @@ import React from 'react';
import { Link } from 'react-router-dom';
import styled from 'styled-components/macro';

import { ANTD_GRAY } from '@app/entity/shared/constants';
import { SEARCH_COLORS } from '@app/entityV2/shared/constants';
import { DomainColoredIcon } from '@app/entityV2/shared/links/DomainColoredIcon';
import { HoverEntityTooltip } from '@app/recommendations/renderer/component/HoverEntityTooltip';
import { formatNumber } from '@app/shared/formatNumber';
import { useEntityRegistry } from '@app/useEntityRegistry';
import { colors } from '@src/alchemy-components';
import { useShowNavBarRedesign } from '@src/app/useShowNavBarRedesign';

import { Domain, EntityType } from '@types';

const Card = styled(Link)<{ $isShowNavBarRedesign?: boolean }>`
border-radius: ${(props) => (props.$isShowNavBarRedesign ? '8px' : '10px')};
background-color: #ffffff;
background-color: ${(props) => props.theme.colors.bg};
padding: 16px;
border: ${(props) => (props.$isShowNavBarRedesign ? `1px solid ${colors.gray[100]}` : '2px solid transparent')};
border: ${(props) =>
props.$isShowNavBarRedesign ? `1px solid ${props.theme.colors.border}` : '2px solid transparent'};

:hover {
border: ${(props) => (props.$isShowNavBarRedesign ? '1px' : '2px')} solid ${SEARCH_COLORS.LINK_BLUE};
border: ${(props) => (props.$isShowNavBarRedesign ? '1px' : '2px')} solid
${(props) => props.theme.colors.hyperlinks};
Copy link
Copy Markdown
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderHover

}

display: flex;
Expand All @@ -39,7 +38,7 @@ const Text = styled.div`

const Name = styled.div`
font-size: 16px;
color: ${ANTD_GRAY[9]};
color: ${(props) => props.theme.colors.text};
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand All @@ -54,7 +53,7 @@ const Counts = styled.div`

const Count = styled.div`
font-size: 14px;
color: ${ANTD_GRAY[7]};
color: ${(props) => props.theme.colors.textTertiary};
overflow: hidden;
text-overflow: ellipsis;
`;
Expand Down
5 changes: 2 additions & 3 deletions ...act/src/app/homeV2/content/tabs/discovery/sections/insight/cards/PopularGlossaryTerms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import styled from 'styled-components';

import analytics, { EventType, HomePageModule } from '@app/analytics';
import { useUserContext } from '@app/context/useUserContext';
import { ANTD_GRAY } from '@app/entity/shared/constants';
import { useRegisterInsight } from '@app/homeV2/content/tabs/discovery/sections/insight/InsightStatusProvider';
import { InsightCard } from '@app/homeV2/content/tabs/discovery/sections/insight/shared/InsightCard';
import InsightCardSkeleton from '@app/homeV2/content/tabs/discovery/sections/insight/shared/InsightCardSkeleton';
Expand All @@ -29,13 +28,13 @@ const Title = styled.div`
display: flex;
align-items: center;
justify-content: start;
color: ${ANTD_GRAY[9]};
color: ${(props) => props.theme.colors.text};
white-space: nowrap;
margin-right: 20px;
`;

const ShowAll = styled(Link)`
color: ${ANTD_GRAY[8]};
color: ${(props) => props.theme.colors.textSecondary};
font-size: 12px;
font-weight: 700;

Expand Down
5 changes: 2 additions & 3 deletions ...ct/src/app/homeV2/content/tabs/discovery/sections/insight/cards/SearchListInsightCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import styled from 'styled-components';

import analytics, { EventType, HomePageModule } from '@app/analytics';
import { useUserContext } from '@app/context/useUserContext';
import { ANTD_GRAY } from '@app/entity/shared/constants';
import { EmbeddedListSearchModal } from '@app/entityV2/shared/components/styled/search/EmbeddedListSearchModal';
import { FilterSet } from '@app/entityV2/shared/components/styled/search/types';
import { useRegisterInsight } from '@app/homeV2/content/tabs/discovery/sections/insight/InsightStatusProvider';
Expand All @@ -31,7 +30,7 @@ const Title = styled.div`
display: flex;
align-items: center;
justify-content: start;
color: ${ANTD_GRAY[9]};
color: ${(props) => props.theme.colors.text};
white-space: nowrap;
margin-right: 20px;
`;
Expand All @@ -42,7 +41,7 @@ const Icon = styled.div`
`;

const ShowAll = styled.div`
color: ${ANTD_GRAY[8]};
color: ${(props) => props.theme.colors.textSecondary};
font-size: 12px;
font-weight: 700;

Expand Down
Loading
Loading