fix(ingest/powerbi): apply lowercase normalization to all upstream lineage URN code paths#16879
Merged
Conversation
github-actions
Bot
added
the
ingestion
Contributor
|
Linear: ING-2149 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Connector Tests ResultsAll connector tests passed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
maggiehays
added
the
needs-review
askumar27
approved these changes
Apr 2, 2026
| # remove_special_characters must run first to expand #(lf) → \n before | ||
| # remove_drop_statement applies line-anchored patterns (USE, GO, SET, etc.) | ||
| query = native_sql_parser.remove_special_characters(query) | ||
| query = native_sql_parser.remove_drop_statement(query) |
Contributor
There was a problem hiding this comment.
Good catch on the ordering!
maggiehays
added
pending-submitter-merge
and removed
needs-review
aviraj-gour
force-pushed
the
powerbi/lineage_case
branch
from
a4917bc to
1a839a2
Compare
askumar27
approved these changes
Apr 6, 2026
Contributor
askumar27
left a comment
askumar27
left a comment
There was a problem hiding this comment.
We will need to improve test coverage for this fix.
| else column_ref.column, | ||
| ) | ||
| for column_ref in cll_info.upstreams | ||
| if column_ref.column |
Contributor
There was a problem hiding this comment.
ColumnRef.column is typed as str (non-optional), so if empty values occur, it indicates an upstream parsing bug that should be surfaced, not masked.
…nd upstream dataset URNs when enabled
aviraj-gour
force-pushed
the
powerbi/lineage_case
branch
from
0fe9b7a to
53b5baa
Compare
alokr-dhub
pushed a commit
that referenced
this pull request
Apr 23, 2026
…neage URN code paths (#16879)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary