feat(ingest): add ability to read other method types than GET for OAS ingest recipes#8303
Merged
Merged
Conversation
github-actions
Bot
added
the
ingestion
hsheth2
suggested changes
Jun 27, 2023
hsheth2
left a comment
hsheth2
left a comment
Contributor
There was a problem hiding this comment.
Overall looking good - would be good to (1) add some tests and (2) revert the extraneous changes
Also, this change probably didn't require an RFC. While I appreciated it and it helped give some context around the PR, rfcs are generally only required for major platform-level changes
added 2 commits
June 27, 2023 15:28
anshbansal
added
the
community-contribution
hsheth2
reviewed
Jul 6, 2023
hsheth2
left a comment
hsheth2
left a comment
Contributor
There was a problem hiding this comment.
Overall the code looks good
It'd be great to add some tests for this as well, even if just small unit tests for some of the new functionality
hsheth2
approved these changes
Jul 18, 2023
hsheth2
added
the
merge-pending-ci
Contributor
|
@jsmilkstein we've had some flakiness in CI lately - just trying to get this green before merging. |
5 tasks
david-leifker
pushed a commit
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened an RFC here datahub-project/rfcs#3, this is the associated code. Allows openapi recipes to display the metadata for non-GET methods, if there's an example in the spec.
Note: currently looking for a good test spec for the tests
Note: A lot of the file changes were from
blackadjusting whitespaceChecklist