Skip to content

Commit 3c46207

Browse files
authored
chore: release 1.6.4 (#606)
* fix: build updates * updated build file
1 parent 231005e commit 3c46207

4 files changed

Lines changed: 20 additions & 3 deletions

File tree

.changeset/clean-numbers-leave.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"kiji-privacy-proxy": patch
3+
---
4+
5+
fix build

src/frontend/config/webpack.config.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,18 @@ module.exports = (env, argv) => {
3838
"@babel/preset-env",
3939
{ targets: { browsers: ["last 2 versions"] } },
4040
],
41-
["@babel/preset-react", { runtime: "automatic" }],
41+
// Tie preset-react's dev flag to the build mode. Babel 8's
42+
// preset-react defaults `development` from NODE_ENV/BABEL_ENV,
43+
// which the npm scripts leave unset — so a `--mode production`
44+
// build would otherwise emit dev `jsxDEV()` calls while webpack
45+
// bundles React's PRODUCTION jsx-dev-runtime (where jsxDEV is
46+
// undefined), throwing "jsxDEV is not a function" and rendering
47+
// a white screen. Keying off isProduction keeps the two halves
48+
// of the build in agreement.
49+
[
50+
"@babel/preset-react",
51+
{ runtime: "automatic", development: !isProduction },
52+
],
4253
"@babel/preset-typescript",
4354
],
4455
},

src/frontend/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"version": "1.6.3",
55
"description": "Dataiku's Kiji Privacy Proxy",
66
"author": "Dataiku - Open Source Lab",
7+
"_comment_electronVersion": "build.electronVersion must stay in sync with the electron devDependency by hand. It can't be omitted: npm workspaces hoist electron to the repo-root node_modules, so electron-builder (run from src/frontend) can't auto-detect it and rejects the '^' range. Keep this note at the top level — electron-builder strictly validates the build object and rejects unknown keys inside it.",
78
"main": "src/electron/electron-main.js",
89
"scripts": {
910
"build": "webpack --config config/webpack.config.js --mode production",
@@ -79,7 +80,7 @@
7980
"build": {
8081
"appId": "com.kiji.proxy",
8182
"productName": "Kiji Privacy Proxy",
82-
"electronVersion": "28.3.3",
83+
"electronVersion": "43.0.0",
8384
"npmRebuild": false,
8485
"icon": "assets/icon.png",
8586
"publish": {

uv.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)