-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add unix socket #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nmartorell
wants to merge
2
commits into
main
Choose a base branch
from
feat/add-unix-socket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−21
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
| } | ||
| }, | ||
| "ProxyPort": ":8080", | ||
| "UnixSocketAccessMode": "USER", | ||
| "Database": { | ||
| "Enabled": false | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import ( | |
| "fmt" | ||
| "io/fs" | ||
| "log" | ||
| "net" | ||
| "net/http" | ||
| "os" | ||
| "path/filepath" | ||
|
|
@@ -180,7 +181,11 @@ func NewServerWithEmbedded(cfg *config.Config, uiFS, modelFS fs.FS, version stri | |
|
|
||
| // Start starts the HTTP server | ||
| func (s *Server) Start() error { | ||
| log.Printf("Starting Kiji Privacy Proxy service on port %s", s.config.ProxyPort) | ||
| if s.config.UnixSocketPath != "" { | ||
| log.Printf("Starting Kiji Privacy Proxy service on Unix socket %s", s.config.UnixSocketPath) | ||
| } else { | ||
| log.Printf("Starting Kiji Privacy Proxy service on port %s", s.config.ProxyPort) | ||
| } | ||
| log.Printf("Forward OpenAI requests to: %s", s.config.Providers.OpenAIProviderConfig.APIDomain) | ||
| log.Printf("Forward Anthropic requests to: %s", s.config.Providers.AnthropicProviderConfig.APIDomain) | ||
| log.Printf("Forward Gemini requests to: %s", s.config.Providers.GeminiProviderConfig.APIDomain) | ||
|
|
@@ -300,7 +305,36 @@ func (s *Server) Start() error { | |
| IdleTimeout: 60 * time.Second, | ||
| } | ||
|
|
||
| return server.ListenAndServe() | ||
| return serveHTTP(server, s.config.UnixSocketPath, s.config.UnixSocketAccessMode) | ||
| } | ||
|
|
||
| func serveHTTP(server *http.Server, socketPath, socketAccessMode string) error { | ||
| if socketPath == "" { | ||
| return server.ListenAndServe() | ||
| } | ||
|
|
||
| if err := os.Remove(socketPath); err != nil && !os.IsNotExist(err) { | ||
| return fmt.Errorf("remove stale Unix socket %s: %w", socketPath, err) | ||
| } | ||
|
|
||
| listener, err := net.Listen("unix", socketPath) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we mkdir -p socketPath ? like in the case that people run in /run/ |
||
| if err != nil { | ||
| return fmt.Errorf("listen on Unix socket %s: %w", socketPath, err) | ||
| } | ||
| defer os.Remove(socketPath) | ||
|
|
||
| socketMode, err := config.SocketAccessModeToChmod(socketAccessMode) | ||
| if err != nil { | ||
| _ = listener.Close() | ||
| return fmt.Errorf("validate Unix socket permissions for %s: %w", socketPath, err) | ||
| } | ||
|
|
||
| if err := os.Chmod(socketPath, os.FileMode(socketMode)); err != nil { | ||
| _ = listener.Close() | ||
| return fmt.Errorf("set Unix socket permissions on %s: %w", socketPath, err) | ||
| } | ||
|
|
||
| return server.Serve(listener) | ||
| } | ||
|
|
||
| // startTransparentProxy starts the transparent proxy server | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose that we expand this to check both in this case a test:
this will silently pass.
We could do a safe check in both:
This way, both fields are validated regardless of mode.