Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-numbers-leave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"kiji-privacy-proxy": patch
---

fix build
13 changes: 12 additions & 1 deletion src/frontend/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,18 @@ module.exports = (env, argv) => {
"@babel/preset-env",
{ targets: { browsers: ["last 2 versions"] } },
],
["@babel/preset-react", { runtime: "automatic" }],
// Tie preset-react's dev flag to the build mode. Babel 8's
// preset-react defaults `development` from NODE_ENV/BABEL_ENV,
// which the npm scripts leave unset — so a `--mode production`
// build would otherwise emit dev `jsxDEV()` calls while webpack
// bundles React's PRODUCTION jsx-dev-runtime (where jsxDEV is
// undefined), throwing "jsxDEV is not a function" and rendering
// a white screen. Keying off isProduction keeps the two halves
// of the build in agreement.
[
"@babel/preset-react",
{ runtime: "automatic", development: !isProduction },
],
"@babel/preset-typescript",
],
},
Expand Down
3 changes: 2 additions & 1 deletion src/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "1.6.3",
"description": "Dataiku's Kiji Privacy Proxy",
"author": "Dataiku - Open Source Lab",
"_comment_electronVersion": "build.electronVersion must stay in sync with the electron devDependency by hand. It can't be omitted: npm workspaces hoist electron to the repo-root node_modules, so electron-builder (run from src/frontend) can't auto-detect it and rejects the '^' range. Keep this note at the top level — electron-builder strictly validates the build object and rejects unknown keys inside it.",
"main": "src/electron/electron-main.js",
"scripts": {
"build": "webpack --config config/webpack.config.js --mode production",
Expand Down Expand Up @@ -79,7 +80,7 @@
"build": {
"appId": "com.kiji.proxy",
"productName": "Kiji Privacy Proxy",
"electronVersion": "28.3.3",
"electronVersion": "43.0.0",
"npmRebuild": false,
"icon": "assets/icon.png",
"publish": {
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading