fix: address @mweitzel review comments

1. Remove dead get_master() from utils.py — replaced by
   extract_master() in dependencies.py, no remaining callers.

2. Replace max_passes=10 magic number in _propagate_restrictions
   with a while loop. Termination is guaranteed because the
   dependency graph is a DAG and propagated_edges prevents
   re-processing. Comment explains why multiple passes are needed
   (part_integrity="cascade" upward propagation).

3. Replace bare except: with except Exception: in Table.delete().
   Lets KeyboardInterrupt and SystemExit propagate without
   attempting cancel_transaction on a dying process.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: dimitri-yatsenko

pixi.lock

@@ -459,9 +459,12 @@ def _propagate_restrictions(self, start_node, mode, part_integrity="enforce"):
 
         restrictions = self._cascade_restrictions if mode == "cascade" else self._restrict_conditions
 
-        # Multiple passes to handle part_integrity="cascade" upward propagation
-        max_passes = 10
-        for _ in range(max_passes):
+        # Multiple passes to handle part_integrity="cascade" upward propagation.
+        # When a part table triggers its master to join the cascade, the master's
+        # other descendants need processing in a subsequent pass. The loop
+        # terminates when no new nodes are added — guaranteed in a DAG.
+        any_new = True
+        while any_new:
             any_new = False
 
             for node in sorted_nodes:
@@ -539,9 +542,6 @@ def _propagate_restrictions(self, start_node, mode, part_integrity="enforce"):
                                 allowed_nodes.update(nx.descendants(self, master_name))
                                 any_new = True
 
-            if not any_new:
-                break
-
     def _apply_propagation_rule(
         self,
         parent_ft,

src/datajoint/diagram.py

@@ -1067,7 +1067,7 @@ def delete(
                     "deleting.".format(child=match["child"])
                 ) from None
             raise DataJointError("Delete blocked by FK in unloaded/inaccessible schema.") from None
-        except:
+        except Exception:
             if transaction:
                 conn.cancel_transaction()
             raise

src/datajoint/table.py

@@ -37,46 +37,6 @@ def user_choice(prompt, choices=("yes", "no"), default=None):
     return response
 
 
-def get_master(full_table_name: str, adapter=None) -> str:
-    """
-    Get the master table name from a part table name.
-
-    If the table name is that of a part table, then return what the master table name would be.
-    This follows DataJoint's table naming convention where a master and a part must be in the
-    same schema and the part table is prefixed with the master table name + ``__``.
-
-    Parameters
-    ----------
-    full_table_name : str
-        Full table name including part.
-    adapter : DatabaseAdapter, optional
-        Database adapter for backend-specific parsing. Default None.
-
-    Returns
-    -------
-    str
-        Supposed master full table name or empty string if not a part table name.
-
-    Examples
-    --------
-    >>> get_master('`ephys`.`session__recording`')  # MySQL part table
-    '`ephys`.`session`'
-    >>> get_master('"ephys"."session__recording"')  # PostgreSQL part table
-    '"ephys"."session"'
-    >>> get_master('`ephys`.`session`')  # Not a part table
-    ''
-    """
-    if adapter is not None:
-        result = adapter.get_master_table_name(full_table_name)
-        return result if result else ""
-
-    # Fallback: handle both MySQL backticks and PostgreSQL double quotes
-    match = re.match(r'(?P<master>(?P<q>[`"])[\w]+(?P=q)\.(?P=q)[\w]+)__[\w]+(?P=q)', full_table_name)
-    if match:
-        return match["master"] + match["q"]
-    return ""
-
-
 def is_camel_case(s):
     """
     Check if a string is in CamelCase notation.