Feat/plugins - deprecate otumate and old plugins#1253
Merged
Conversation
github-actions
bot
added
enhancement
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated plugin functionality from DataJoint, specifically deprecating the otumate library and associated plugin verification system. The changes simplify the codebase by removing cryptographic verification of plugins and the plugin loading mechanism.
Key changes:
- Removes the entire plugin verification system including cryptographic signature checking
- Eliminates dependencies on otumate and cryptography libraries
- Removes plugin-based connection handling and custom attribute adapters
- Adds comprehensive documentation for the three-part make pattern for long computations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_plugin.py | Completely removes all plugin-related tests |
| pyproject.toml | Removes otumate and cryptography dependencies |
| docs/src/compute/populate.md | Adds extensive documentation for three-part make pattern |
| datajoint/plugin.py | Removes entire plugin module with verification logic |
| datajoint/errors.py | Simplifies DataJointError by removing plugin warning mechanism |
| datajoint/connection.py | Removes plugin-based connection hooks and simplifies connection logic |
| datajoint/attribute_adapter.py | Removes plugin-based attribute adapter loading |
| .devcontainer/devcontainer.json | Adds SSH agent mounting for development environment |
ttngu207
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #1252 and initial part of #1251