refactor: Removed deprecation by switching to importlib.metadata#1254
Closed
tabedzki wants to merge 1 commit intodatajoint:masterfrom
Closed
refactor: Removed deprecation by switching to importlib.metadata#1254tabedzki wants to merge 1 commit intodatajoint:masterfrom
tabedzki wants to merge 1 commit intodatajoint:masterfrom
Conversation
docs: Correct spelling of 'declaration' in indexes documentation style: Consistently format import statements in plugin and test files
28cef1a to
72be655
Compare
Member
|
This PR is stale because it has been open for 45 days with no activity. |
Member
|
@tabedzki I am closing this. We are preparing DataJoint 2.0 for release in two weeks, which upgrades the plugin infrastructure. |
Contributor
Author
|
@dimitri-yatsenko Can this be introduced into the 0.14.x EOL branch? When running pytest with datajoint, the deprecation warning keeps popping up and I believe that this is more sustainable than pinning setuptools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the larger overhaul of the plugin architecture is being considered (#1251, this is a small fix to move away from
pkg_resourcesand useimportlib.metadata.Nothing else has changed as this is solely to remove the deprecation warning when importing datajoint.
Edit: I tested it for Python 3.9 to 3.12 by doing