Impr/modernize pre commit#1273
Merged
dimitri-yatsenko merged 8 commits intodatajoint:pre/v2.0from Dec 12, 2025
Merged
Conversation
|
This PR is stale because it has been open for 45 days with no activity. |
github-actions
Bot
added
the
stale
| [tool.ruff] | ||
| # Equivalent to flake8 configuration | ||
| line-length = 127 | ||
| target-version = "py39" |
Member
There was a problem hiding this comment.
Should we change to py310?
Contributor
Author
There was a problem hiding this comment.
probably only when we formally drop python 3.9
dimitri-yatsenko
approved these changes
Dec 10, 2025
github-actions
Bot
removed
the
stale
dimitri-yatsenko
approved these changes
Dec 12, 2025
Contributor
Author
|
I am fixing some test failures locally, I will ping you when everything is green |
Contributor
Author
|
tests are all passing! I think this is good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR modernizes the pre-commit workflow via the following changes:
Ruff is flagging a pretty large volume of code here. it will take some time to fix those problems, but it's ultimately worth it. not sure if this should be done in this PR or a later effort.