Merge pull request #215 from datakind/revert-208-feat/legacy-school-classifier

Revert "feat: legacy school type with any-format uploads, PII check, and Edvise Schema (ES) naming"

Author: vishpillai123

src/webapp/database.py

@@ -218,10 +218,6 @@ class InstTable(Base):
     edvise_id: Mapped[str | None] = mapped_column(
         String(VAR_CHAR_LENGTH), nullable=True
     )
-    # Only populated for Legacy schools (any-format uploads).
-    legacy_id: Mapped[str | None] = mapped_column(
-        String(VAR_CHAR_LENGTH), nullable=True
-    )
     created_at: Mapped[datetime.datetime] = mapped_column(
         DateTime(timezone=True),
         server_default=func.now(),

src/webapp/fixtures/validation_error_snapshots/mixed_types_multiple_columns.txt

@@ -8,4 +8,4 @@ Column 'Score' has validation errors:
   • Row 3: Validation failed for greater_than(0) check. Current value: found '-5'
 
 Column 'Student ID' has validation errors:
-  • Row 1: Value must be at least 3 characters long. Current value: found 'AB'
+  • Row 1: Value must be at least 3 characters long. Current value: found '****' (value masked for privacy)

src/webapp/gcsutil.py

@@ -341,8 +341,8 @@ def validate_file(
             allowed_schemas: List of schema/model names allowed.
             base_schema: Base schema dict.
             inst_schema: Optional extension schema with institutions.* blocks.
-            institution_id: Key into inst_schema["institutions"]: "edvise", "pdp",
-                "legacy" (any-format uploads), or institution UUID for custom. Default "pdp".
+            institution_id: Key into inst_schema["institutions"]: "edvise", "pdp", or
+                institution UUID for custom. Default "pdp" for backward compatibility.
             institution_identifier: Optional institution ID (e.g. UUID). Reserved for
                 future use; Edvise uses JSON-based validation only (different shape).