Skip to content

Commit 449a3ac

Browse files
Mesh-achMesh-ach
committed
fix: base and pdp schema
1 parent 71b605e commit 449a3ac

2 files changed

Lines changed: 15 additions & 210 deletions

File tree

‎src/webapp/validation_schemas/base_schema.json‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,7 @@
100100
"nullable": true,
101101
"required": false,
102102
"aliases": [],
103-
"checks": [
104-
{"type": "isin", "args": [["employed", "unemployed", "unemployed"]]}
105-
]
103+
"checks": []
106104
},
107105
"disability_status": {
108106
"dtype": "string",
@@ -257,7 +255,7 @@
257255
"required": false,
258256
"aliases": ["pell_status_first_year"],
259257
"checks": [
260-
{"type": "isin", "args": [["true", "false", "yes", "no", "Y", "N"]]}
258+
{"type": "isin", "args": [["true", "false", "yes", "no", "Y", "N", "UK"]]}
261259
]
262260
}
263261
}
@@ -291,8 +289,7 @@
291289
"required": false,
292290
"aliases": ["time_status"],
293291
"checks": [
294-
{"type": "str_length", "args": [], "kwargs": {"min_value": 1}},
295-
{"type": "isin", "args": [["FT", "PT", "Others", "full_time", "part_time", "unknown"]]}
292+
{"type": "str_length", "args": [], "kwargs": {"min_value": 1}}
296293
]
297294
},
298295
"student_type": {
@@ -392,7 +389,7 @@
392389
"number_of_credits_earned": {
393390
"dtype": "float64",
394391
"coerce": true,
395-
"nullable": false,
392+
"nullable": true,
396393
"required": true,
397394
"aliases": ["credits_earned", "ug_earn", "number_of_credits_earned_year_1", "number_of_credits_earned_year_2",
398395
"number_of_credits_earned_year_3", "number_of_credits_earned_year_4"],

‎src/webapp/validation_schemas/pdp_schema_extension.json‎

Lines changed: 11 additions & 203 deletions
Original file line numberDiff line numberDiff line change
@@ -302,25 +302,7 @@
302302
}
303303
]
304304
},
305-
"first_year_to_associates_or_certificate_at_cohort_inst.": {
306-
"dtype": "category",
307-
"categories": [
308-
0,
309-
2,
310-
1,
311-
6,
312-
4,
313-
5,
314-
3,
315-
7
316-
],
317-
"coerce": true,
318-
"nullable": false,
319-
"required": true,
320-
"aliases": [],
321-
"checks": []
322-
},
323-
"first_year_to_associates_or_certificate_at_other_inst.": {
305+
"first_year_to_associates_or_certificate_at_other_inst": {
324306
"dtype": "category",
325307
"categories": [
326308
0,
@@ -339,7 +321,7 @@
339321
"aliases": [],
340322
"checks": []
341323
},
342-
"first_year_to_bachelor_at_other_inst.": {
324+
"first_year_to_bachelor_at_other_inst": {
343325
"dtype": "category",
344326
"categories": [
345327
0,
@@ -358,7 +340,7 @@
358340
"aliases": [],
359341
"checks": []
360342
},
361-
"first_year_to_bachelors_at_cohort_inst.": {
343+
"first_year_to_bachelors_at_cohort_inst": {
362344
"dtype": "category",
363345
"categories": [
364346
0,
@@ -449,14 +431,6 @@
449431
"aliases": [],
450432
"checks": []
451433
},
452-
"gpa_group_year_1": {
453-
"dtype": "float64",
454-
"coerce": true,
455-
"nullable": false,
456-
"required": true,
457-
"aliases": [],
458-
"checks": []
459-
},
460434
"institution_id": {
461435
"dtype": "float64",
462436
"coerce": true,
@@ -690,63 +664,7 @@
690664
"aliases": [],
691665
"checks": []
692666
},
693-
"years_to_associates_or_certificate_at_cohort_inst.": {
694-
"dtype": "category",
695-
"categories": [
696-
0,
697-
2,
698-
1,
699-
6,
700-
4,
701-
5,
702-
3,
703-
7
704-
],
705-
"coerce": true,
706-
"nullable": false,
707-
"required": true,
708-
"aliases": [],
709-
"checks": []
710-
},
711-
"years_to_associates_or_certificate_at_other_inst.": {
712-
"dtype": "category",
713-
"categories": [
714-
0,
715-
2,
716-
5,
717-
3,
718-
6,
719-
1,
720-
8,
721-
4,
722-
7
723-
],
724-
"coerce": true,
725-
"nullable": false,
726-
"required": true,
727-
"aliases": [],
728-
"checks": []
729-
},
730-
"years_to_bachelor_at_other_inst.": {
731-
"dtype": "category",
732-
"categories": [
733-
0,
734-
3,
735-
4,
736-
5,
737-
6,
738-
7,
739-
8,
740-
1,
741-
2
742-
],
743-
"coerce": true,
744-
"nullable": false,
745-
"required": true,
746-
"aliases": [],
747-
"checks": []
748-
},
749-
"years_to_bachelors_at_cohort_inst.": {
667+
"years_to_bachelors_at_cohort_inst": {
750668
"dtype": "category",
751669
"categories": [
752670
0,
@@ -844,15 +762,15 @@
844762
"checks": []
845763
},
846764
"completeddevenglishy1": {
847-
"dtype": "float64",
765+
"dtype": "string",
848766
"coerce": true,
849767
"nullable": true,
850768
"required": true,
851769
"aliases": [],
852770
"checks": []
853771
},
854772
"completeddevmathy1": {
855-
"dtype": "float64",
773+
"dtype": "string",
856774
"coerce": true,
857775
"nullable": true,
858776
"required": true,
@@ -1005,7 +923,7 @@
1005923
"aliases": [],
1006924
"checks": []
1007925
},
1008-
"first_year_to_associates_or_certificate_at_cohort_inst.": {
926+
"first_year_to_associates_or_certificate_at_cohort_inst": {
1009927
"dtype": "category",
1010928
"categories": [
1011929
0,
@@ -1023,80 +941,6 @@
1023941
"aliases": [],
1024942
"checks": []
1025943
},
1026-
"first_year_to_associates_or_certificate_at_other_inst.": {
1027-
"dtype": "category",
1028-
"categories": [
1029-
0,
1030-
2,
1031-
5,
1032-
3,
1033-
6,
1034-
1,
1035-
8,
1036-
4,
1037-
7
1038-
],
1039-
"coerce": true,
1040-
"nullable": false,
1041-
"required": true,
1042-
"aliases": [],
1043-
"checks": []
1044-
},
1045-
"first_year_to_bachelor_at_other_inst.": {
1046-
"dtype": "category",
1047-
"categories": [
1048-
0,
1049-
3,
1050-
4,
1051-
5,
1052-
6,
1053-
7,
1054-
8,
1055-
1,
1056-
2
1057-
],
1058-
"coerce": true,
1059-
"nullable": false,
1060-
"required": true,
1061-
"aliases": [],
1062-
"checks": []
1063-
},
1064-
"first_year_to_bachelors_at_cohort_inst.": {
1065-
"dtype": "category",
1066-
"categories": [
1067-
0,
1068-
3,
1069-
4,
1070-
5,
1071-
2,
1072-
6,
1073-
7,
1074-
1,
1075-
8
1076-
],
1077-
"coerce": true,
1078-
"nullable": false,
1079-
"required": true,
1080-
"aliases": [],
1081-
"checks": [
1082-
{
1083-
"type": "isin",
1084-
"args": [
1085-
[
1086-
0,
1087-
3,
1088-
4,
1089-
5,
1090-
2,
1091-
6,
1092-
7,
1093-
1,
1094-
8
1095-
]
1096-
]
1097-
}
1098-
]
1099-
},
1100944
"foreign_language_completion": {
1101945
"dtype": "float64",
1102946
"coerce": true,
@@ -1225,7 +1069,7 @@
12251069
]
12261070
},
12271071
"gpa_group_year_1": {
1228-
"dtype": "float64",
1072+
"dtype": "string",
12291073
"coerce": true,
12301074
"nullable": false,
12311075
"required": true,
@@ -1646,7 +1490,7 @@
16461490
}
16471491
]
16481492
},
1649-
"years_to_associates_or_certificate_at_cohort_inst.": {
1493+
"years_to_associates_or_certificate_at_cohort_inst": {
16501494
"dtype": "category",
16511495
"categories": [
16521496
0,
@@ -1680,7 +1524,7 @@
16801524
}
16811525
]
16821526
},
1683-
"years_to_associates_or_certificate_at_other_inst.": {
1527+
"years_to_associates_or_certificate_at_other_inst": {
16841528
"dtype": "category",
16851529
"categories": [
16861530
0,
@@ -1716,7 +1560,7 @@
17161560
}
17171561
]
17181562
},
1719-
"years_to_bachelor_at_other_inst.": {
1563+
"years_to_bachelor_at_other_inst": {
17201564
"dtype": "category",
17211565
"categories": [
17221566
0,
@@ -1751,42 +1595,6 @@
17511595
]
17521596
}
17531597
]
1754-
},
1755-
"years_to_bachelors_at_cohort_inst.": {
1756-
"dtype": "category",
1757-
"categories": [
1758-
0,
1759-
3,
1760-
4,
1761-
5,
1762-
2,
1763-
6,
1764-
7,
1765-
1,
1766-
8
1767-
],
1768-
"coerce": true,
1769-
"nullable": false,
1770-
"required": true,
1771-
"aliases": [],
1772-
"checks": [
1773-
{
1774-
"type": "isin",
1775-
"args": [
1776-
[
1777-
0,
1778-
3,
1779-
4,
1780-
5,
1781-
2,
1782-
6,
1783-
7,
1784-
1,
1785-
8
1786-
]
1787-
]
1788-
}
1789-
]
17901598
}
17911599
}
17921600
},

0 commit comments

Comments
 (0)