Skip to content

Commit 86f925e

Browse files
authored
Merge pull request #111 from datakind/Validation-Errors
fix: adjusted validation schemas
2 parents a429b42 + 9402e96 commit 86f925e

3 files changed

Lines changed: 127 additions & 1018 deletions

File tree

src/webapp/routers/data.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -862,6 +862,9 @@ def infer_models_from_filename(file_path: str, institution_id: str) -> List[str]
862862
if "cohort" in name:
863863
inferred.add("STUDENT")
864864
inferred.add("SEMESTER")
865+
if "course" not in name and ("ar" in name or "deidentified" in name):
866+
inferred.add("STUDENT")
867+
inferred.add("SEMESTER")
865868

866869
if not inferred:
867870
logging.error(

src/webapp/validation_schemas/base_schema.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"student_id": {
99
"dtype": "string",
1010
"coerce": true,
11-
"nullable": false,
11+
"nullable": true,
1212
"required": true,
1313
"aliases": ["student_id", "guid", "student_guid", "study_id"],
1414
"checks": [
@@ -63,7 +63,7 @@
6363
"dtype": "string",
6464
"coerce": true,
6565
"nullable": true,
66-
"required": true,
66+
"required": false,
6767
"aliases": ["racial_identification", "ipeds_race"],
6868
"checks": []
6969
},
@@ -373,7 +373,7 @@
373373
"dtype": "float64",
374374
"coerce": true,
375375
"nullable": true,
376-
"required": true,
376+
"required": false,
377377
"aliases": ["credits_attempted", "ug_att", "number_of_credits_attempted_year_1", "number_of_credits_attempted_year_2",
378378
"number_of_credits_attempted_year_3", "number_of_credits_attempted_year_4"],
379379
"checks": []
@@ -390,15 +390,15 @@
390390
"dtype": "float64",
391391
"coerce": true,
392392
"nullable": true,
393-
"required": true,
393+
"required": false,
394394
"aliases": ["credits_earned", "ug_earn", "number_of_credits_earned_year_1", "number_of_credits_earned_year_2",
395395
"number_of_credits_earned_year_3", "number_of_credits_earned_year_4"],
396396
"checks": [{"type": "ge", "args": [0.0]}]
397397
},
398398
"course_pass_rate": {
399399
"dtype": "float64",
400400
"coerce": true,
401-
"nullable": false,
401+
"nullable": true,
402402
"required": false,
403403
"aliases": [],
404404
"checks": [{"type": "in_range", "args": [0.0, 1.0]}]
@@ -585,7 +585,7 @@
585585
},
586586
"years_enrolled": {
587587
"dtype": "string",
588-
"nullable": false,
588+
"nullable": true,
589589
"required": false,
590590
"aliases": [],
591591
"checks": [{"type": "str_length", "args": [], "kwargs": {"min_value": 1}}]

0 commit comments

Comments
 (0)