Skip to content

Commit a0906d5

Browse files
authored
Revert "Revert "feat: legacy school type with any-format uploads, PII check, and Edvise Schema (ES) naming""
1 parent 1d7824d commit a0906d5

16 files changed

Lines changed: 1325 additions & 379 deletions

src/webapp/database.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,10 @@ class InstTable(Base):
218218
edvise_id: Mapped[str | None] = mapped_column(
219219
String(VAR_CHAR_LENGTH), nullable=True
220220
)
221+
# Only populated for Legacy schools (any-format uploads).
222+
legacy_id: Mapped[str | None] = mapped_column(
223+
String(VAR_CHAR_LENGTH), nullable=True
224+
)
221225
created_at: Mapped[datetime.datetime] = mapped_column(
222226
DateTime(timezone=True),
223227
server_default=func.now(),

src/webapp/fixtures/validation_error_snapshots/mixed_types_multiple_columns.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ Column 'Score' has validation errors:
88
• Row 3: Validation failed for greater_than(0) check. Current value: found '-5'
99

1010
Column 'Student ID' has validation errors:
11-
• Row 1: Value must be at least 3 characters long. Current value: found '****' (value masked for privacy)
11+
• Row 1: Value must be at least 3 characters long. Current value: found 'AB'

src/webapp/gcsutil.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@ def validate_file(
341341
allowed_schemas: List of schema/model names allowed.
342342
base_schema: Base schema dict.
343343
inst_schema: Optional extension schema with institutions.* blocks.
344-
institution_id: Key into inst_schema["institutions"]: "edvise", "pdp", or
345-
institution UUID for custom. Default "pdp" for backward compatibility.
344+
institution_id: Key into inst_schema["institutions"]: "edvise", "pdp",
345+
"legacy" (any-format uploads), or institution UUID for custom. Default "pdp".
346346
institution_identifier: Optional institution ID (e.g. UUID). Reserved for
347347
future use; Edvise uses JSON-based validation only (different shape).
348348

0 commit comments

Comments
 (0)