Avoid protected pydantic ns in cfg schema

using "model" seems really problematic -- wth, pydantic!!

Author: bdewilde

notebooks/pdp/config-v2-TEMPLATE.toml

@@ -45,7 +45,7 @@ timeout_minutes = 10
 [models.graduation]
 experiment_id = "EXPERIMENT_ID"
 run_id = "RUN_ID"
-model_type = "sklearn"
+framework = "sklearn"
 
 [inference]
 num_top_features = 5

src/student_success_tool/configs/schemas/pdp_v2.py

@@ -186,7 +186,7 @@ class DatasetConfig(pyd.BaseModel):
 class ModelConfig(pyd.BaseModel):
     experiment_id: str
     run_id: str
-    model_type: t.Optional[t.Literal["sklearn", "xgboost", "lightgbm"]] = None
+    framework: t.Optional[t.Literal["sklearn", "xgboost", "lightgbm"]] = None
 
     @pyd.computed_field  # type: ignore[misc]
     @property

tests/configs/schemas/test_pdp_v2.py

@@ -60,7 +60,7 @@ def template_cfg_str():
     [models.graduation]
     experiment_id = "EXPERIMENT_ID"
     run_id = "RUN_ID"
-    model_type = "sklearn"
+    framework = "sklearn"
 
     [inference]
     num_top_features = 5