Merge pull request #117 from datakind/develop

adjust error logging

Author: Mesh-ach

src/webapp/databricks.py

@@ -131,7 +131,7 @@ def run_pdp_inference(
             or not check_types(req.filepath_to_type.values(), SchemaType.STUDENT)
         ):
             raise ValueError(
-                "run_pdp_inference() requires PDP_COURSE and PDP_COHORT type files to run."
+                "run_pdp_inference() requires COURSE and STUDENT type files to run."
             )
         w = WorkspaceClient(
             host=databricks_vars["DATABRICKS_HOST_URL"],

src/webapp/routers/models.py

@@ -30,7 +30,8 @@
     ModelTable,
     JobTable,
 )
-
+import traceback
+import logging
 from ..gcsdbutils import update_db_from_bucket
 
 from ..gcsutil import StorageControl
@@ -550,9 +551,11 @@ def trigger_inference_run(
     try:
         res = databricks_control.run_pdp_inference(db_req)
     except Exception as e:
+        tb = traceback.format_exc()
+        logging.error(f"Databricks run failure:\n{tb}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="Databricks run_pdp_inference error. " + str(e),
+            detail=f"Databricks run_pdp_inference error. Error = {str(e)}",
         ) from e
     triggered_timestamp = datetime.now()
     job = JobTable(