Skip to content

adjust error logging #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mesh-ach merged 1 commit into from
Jun 18, 2025
Merged

adjust error logging #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webapp/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def run_pdp_inference(
or not check_types(req.filepath_to_type.values(), SchemaType.STUDENT)
):
raise ValueError(
"run_pdp_inference() requires PDP_COURSE and PDP_COHORT type files to run."
"run_pdp_inference() requires COURSE and STUDENT type files to run."
)
w = WorkspaceClient(
host=databricks_vars["DATABRICKS_HOST_URL"],
Expand Down
7 changes: 5 additions & 2 deletions src/webapp/routers/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
ModelTable,
JobTable,
)

import traceback
import logging
from ..gcsdbutils import update_db_from_bucket

from ..gcsutil import StorageControl
Expand Down Expand Up @@ -550,9 +551,11 @@ def trigger_inference_run(
try:
res = databricks_control.run_pdp_inference(db_req)
except Exception as e:
tb = traceback.format_exc()
logging.error(f"Databricks run failure:\n{tb}")
raise HTTPException(
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
detail="Databricks run_pdp_inference error. " + str(e),
detail=f"Databricks run_pdp_inference error. Error = {str(e)}",
) from e
triggered_timestamp = datetime.now()
job = JobTable(
Expand Down
Loading