Conversation
Add EDA Dashboard Endpoint with Caching
fix: adjusted model card file path
Replace 'Edvise schema' with 'Edvise Schema (ES)' in docstrings, comments, and user-facing error messages so the schema type is distinguished from the Edvise product (ES convention). Made-with: Cursor
- Fetch institution before filename inference; set allowed_schemas to UNKNOWN when inference fails for legacy (non-legacy still get 422 for non-descriptive names) - Refactor validation_helper into helpers under 50 lines; add full docstrings, early empty-filename and invalid inst_id validation, log before 404 - Add unit tests for _infer_allowed_schemas_from_filename and _ext_models_set - Add integration tests: empty filename 422, invalid inst_id 404, edvise non-descriptive filename 422, duplicate validate idempotent - Fix mypy and ruff/black in data.py and data_test.py - Add PR_DESCRIPTION.md for feature branch Made-with: Cursor
Made-with: Cursor
…splay Made-with: Cursor
- Use converter_func_cohort by default for PDP cohort validation (filters DE/DS/SE) - Add optional pdp_cohort_converter_func and pdp_course_converter_func to validate_file_reader and validate_dataset for school-specific overrides - Course validation tries custom converter first, then default handling_duplicates - Validate converter args are callable; convert converter/read failures to HardValidationError so API returns 400 with context - Add PDPConverterFunc type; extract helpers to meet 50-line and error-handling rules Made-with: Cursor
- Add unreachable return after with block in _validate_pdp_with_edvise_read - Use cast(Any, ...) in tests that pass non-callables to converter params Made-with: Cursor
…pload feat: use PDP cohort converter and support custom converters
chore: remove real institution names
fix: use latest edvise EdaSummary
chore: bump edvise version to 0.1.12
Collaborator
Author
|
Looks okay to me, but need someone else's approval to merge. |
feat: legacy school type with any-format uploads, PII check, and Edvise Schema (ES) naming
…and Edvise Schema (ES) naming"
…lassifier Revert "feat: legacy school type with any-format uploads, PII check, and Edvise Schema (ES) naming"
chapmanhk
approved these changes
Mar 7, 2026
chapmanhk
left a comment
chapmanhk
left a comment
Collaborator
There was a problem hiding this comment.
Looks like we're ready to go. Just noting that before we actually merge, I'll need to run the database scripts to get edvise added into the tables (laid out here #196). So give me a heads up before we click merge and I can get that done.
Collaborator
Author
Yeah we're ready to merge! Go ahead and work on the database update and we'll come back here and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.