Skip to content

feat(api): simplify create model request to name only #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrmaloof wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(api): simplify create model request to name only #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/webapp/routers/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ class ModelCreationRequest(BaseModel):
"""Model creation request object."""

name: str
# valid = False, means the model is not ready for use.
valid: bool = False
schema_configs: list[list[SchemaConfigObj]]


class ModelInfo(BaseModel):
Expand All @@ -108,7 +105,7 @@ class ModelInfo(BaseModel):
inst_id: str
# User id of created_by.
created_by: str | None = None
valid: bool = False
valid: bool = True
deleted: bool | None = None


Expand Down Expand Up @@ -215,8 +212,7 @@ def create_model(
name=req.name,
inst_id=str_to_uuid(inst_id),
created_by=str_to_uuid(current_user.user_id),
valid=req.valid,
schema_configs=jsonpickle.encode(req.schema_configs),
valid=True,
)
local_session.get().add(model)
local_session.get().commit()
Expand Down
Loading