refactor(create-model): simplify create model UI to a single name input, use Edvise Design System for input errors#279
Merged
Conversation
# Conflicts: # resources/css/app.css
# Conflicts: # resources/css/app.css
# Conflicts: # resources/js/Pages/CreateModel.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the Create Model admin page to a single model name field and aligns form styling and validation errors with the Edvise Design System.
UI (
CreateModel.jsx){ name }toPOST /create-modelinput.error,text-danger)aria-invalid,aria-describedby,role="alert")Backend proxy (
ApiController::createModelApi)vers_id,valid, andschema_configsto the APIStyles
app.css: label defaults;input.errorusesborder-dangeron hover/focustailwind.config.js:dangercolor tokensCompanion change: Pairs with the edvise-api PR that simplifies
POST /institutions/{inst_id}/models/to acceptnameonly and defaultvalid=trueon create.Deployment Readiness*
Testing
Describe or check:
Notes: No automated tests cover this page today. Manually verified as a DATAKINDER user:
text-dangerDeployment Notes
Describe or check:
Deploy with the matching edvise-api change so create-model does not send removed fields. No migrations or env var changes.
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
valid=true).result_areasuccess/error copy be refined in a follow-up (still uses simple “Done” / JSON for some errors)?Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional