Skip to content

fix edge-case logic in screening endpoints#222

Merged
bdewilde merged 2 commits into
developfrom
bugfixes-in-screening-endpoints
May 15, 2026
Merged

fix edge-case logic in screening endpoints#222
bdewilde merged 2 commits into
developfrom
bugfixes-in-screening-endpoints

Conversation

@bdewilde

@bdewilde bdewilde commented May 12, 2026

Copy link
Copy Markdown
Member

changes

  • fixes screening duplication checks in cases where an admin submits a screening on behalf of another user -- super niche, but i noticed this as a legit bug
  • standardizes event listener logic to always get a fresh study record after screening submission; this is super nit-picky, but could theoretically have caused inconsistency on screening submission in the past (i doubt it though)

context

https://app.asana.com/1/6325821815997/project/1206730431337718/task/1214036395387356?focus=true

i'm not sure the mystery behavior in that ticket is even real and/or if these changes fix it, but still worth addressing while i was digging deep

questions

like PR #220, this is also meant as a production fix; should we merge it into the main branch of develop?

@bdewilde bdewilde marked this pull request as ready for review May 13, 2026 00:19
@bdewilde bdewilde requested review from mrmaloof and sophiaharms May 13, 2026 00:42
@bdewilde bdewilde merged commit 0bd1caf into develop May 15, 2026
6 checks passed
@bdewilde bdewilde deleted the bugfixes-in-screening-endpoints branch May 15, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants