Add to_mongo_doc method to ItemVersionModel to protect None values#1863
Open
be-smith wants to merge 2 commits into
Open
Add to_mongo_doc method to ItemVersionModel to protect None values#1863be-smith wants to merge 2 commits into
be-smith wants to merge 2 commits into
Conversation
…d versions (pydantic 1 to 2 change)
…s data to not have it's empty keys stripped when saving a version
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ml-evs/bump-pydantic-final-final #1863 +/- ##
==================================================================
Coverage 79.57% 79.58%
==================================================================
Files 83 83
Lines 7603 7856 +253
==================================================================
+ Hits 6050 6252 +202
- Misses 1553 1604 +51
🚀 New features to boost your workflow:
|
datalab
 |
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/pydantic_vc_fix_basemodel
|
| Run status |
|
| Run duration | 24m 33s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
538
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the data key doesn't have None values removed from it by adding a custom method. Alternative fix to #1859
Solves #1861