feat(datasets): BI-6047 dataset import without a connection

Author: KonstantAnxiety

lib/dl_api_lib/dl_api_lib/app/control_api/resources/dataset.py

@@ -350,8 +350,18 @@ def generate_dataset_location(cls, body: dict) -> EntryLocation:
 
     @classmethod
     def replace_conn_ids(cls, data: dict, conn_id_mapping: dict) -> None:
-        for sources in data["dataset"]["sources"]:
-            sources["connection_id"] = conn_id_mapping[sources["connection_id"]]
+        for source in data["dataset"]["sources"]:
+            assert isinstance(source, dict)
+            fake_conn_id = source["connection_id"]
+            if fake_conn_id not in conn_id_mapping:
+                LOGGER.info(
+                    'Can not find "%s" in conn id mapping for source with id %s, going to replace it with a fake connection',
+                    fake_conn_id,
+                    source.get("id"),
+                )
+                source["connection_id"] = "0000000000000"  # TODO which ID should we use here?
+            else:
+                source["connection_id"] = conn_id_mapping[fake_conn_id]
 
     @put_to_request_context(endpoint_code="DatasetImport")
     @schematic_request(

lib/dl_api_lib_testing/dl_api_lib_testing/connector/dataset_suite.py

@@ -126,6 +126,16 @@ def test_export_import_dataset(
             "data": {"workbook_id": None, "dataset": export_resp.json["dataset"]},
         }
         import_resp = control_api.import_dataset(data=import_data, bi_headers=bi_headers)
-        assert import_resp.status_code == 200, import_resp.json["dataset"] != export_resp.json["dataset"]
+        assert import_resp.status_code == 200, f"{import_resp.json} != {export_resp.json}"
+
+        control_api.delete_dataset(dataset_id=import_resp.json["id"])
+
+        # test import without a connection
+        import_data: dict = {
+            "id_mapping": {},  # empty
+            "data": {"workbook_id": None, "dataset": export_resp.json["dataset"]},
+        }
+        import_resp = control_api.import_dataset(data=import_data, bi_headers=bi_headers)
+        assert import_resp.status_code == 200, f"{import_resp.json} != {export_resp.json}"
 
         control_api.delete_dataset(dataset_id=import_resp.json["id"])