feat(connectors): BI-6992 Fix postgres ARRAY type detection#1535
feat(connectors): BI-6992 Fix postgres ARRAY type detection#1535catsona wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes PostgreSQL connector metadata inference for ARRAY columns by correcting OID-to-type mappings and adding regression tests to validate BI type detection for common array element types.
Changes:
- Corrected PostgreSQL
pg_type.oidmappings for_textand_numericarrays in the adapter. - Added API-level DashSQL tests validating BI type detection for integer, float/numeric, and string array columns (both table-based and query-based).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/dl_connector_postgresql/dl_connector_postgresql/core/postgresql_base/adapters_base_postgres.py |
Fixes OID mappings used to infer SQLAlchemy/native types for PostgreSQL array columns. |
lib/dl_connector_postgresql/dl_connector_postgresql_tests/db/api/test_array_types.py |
Adds regression tests ensuring array BI types are detected correctly from metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from dl_connector_postgresql_tests.db.api.base import PostgreSQLDashSQLConnectionTest | ||
|
|
||
|
|
||
| class TestPostgreSQLArrayTypes(PostgreSQLDashSQLConnectionTest, DefaultDashSQLTestSuite): |
There was a problem hiding this comment.
What do these tests have to do with dashsql? Don't these tests look more suitable for type recognition?
There was a problem hiding this comment.
I've implemented similar to YDB connector, where type recognition is tested using DashSQL:
There was a problem hiding this comment.
The original issue is related to SQL-datasource, not dashsql
There was a problem hiding this comment.
moved test to type recognition
37acd74 to
68aefa2
Compare
No description provided.