Merge pull request #443 from nblumhardt/metric-kind-fix

KodrAus · web-flow · commit b79559771a08 · 2026-02-05T12:28:54.000+10:00
Use Sum rather than Counter for sample delta-temporality counter metric kind
diff --git a/src/Roastery/Metrics/RoasteryMetrics.cs b/src/Roastery/Metrics/RoasteryMetrics.cs
@@ -69,8 +69,8 @@ public IEnumerable<LogEvent> ToLogEvents(ILogger logger, PropertyNameMapping pro
                 timestamp,
                 new Dictionary<string, object>
                 {
-                    { "OrdersCreated", new { kind = "Counter", unit = "orders", description = "The total number of orders created in the system" } },
-                    { "OrdersShipped", new { kind = "Counter", unit = "orders", description = "The total number of orders shipped in the system" } }
+                    { "OrderCreated", new { kind = "Sum", unit = "orders", description = "An order was created" } },
+                    { "OrderShipped", new { kind = "Sum", unit = "orders", description = "An order was shipped" } }
                 },
                 new
                 {

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,8 @@ public IEnumerable<LogEvent> ToLogEvents(ILogger logger, PropertyNameMapping pro`
`69`	`69`	`timestamp,`
`70`	`70`	`new Dictionary<string, object>`
`71`	`71`	`{`
`72`		`- { "OrdersCreated", new { kind = "Counter", unit = "orders", description = "The total number of orders created in the system" } },`
`73`		`- { "OrdersShipped", new { kind = "Counter", unit = "orders", description = "The total number of orders shipped in the system" } }`
	`72`	`+ { "OrderCreated", new { kind = "Sum", unit = "orders", description = "An order was created" } },`
	`73`	`+ { "OrderShipped", new { kind = "Sum", unit = "orders", description = "An order was shipped" } }`
`74`	`74`	`},`
`75`	`75`	`new`
`76`	`76`	`{`