Skip to content

Commit def00a8

Browse files
Xavier MedranoXavier Medrano
authored andcommitted
linting
1 parent bedad92 commit def00a8

4 files changed

Lines changed: 21 additions & 18 deletions

File tree

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ repos:
77
- id: trailing-whitespace
88

99
- repo: https://github.com/psf/black
10-
rev: 22.3.0
10+
rev: 26.1.0
1111
hooks:
1212
- id: black
1313
exclude: ^(map/migrations/)

README.md

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
1-
# DataMade Code Challenge: React Map
1+
# DataMade Code Challenge: React Map
22

33
---
44

55
Welcome to the DataMade code challenge! 👋
66

77
## Contents
8+
89
1. [Overview](#overview)
910
2. [Installation](#installation)
1011
3. [Completing the Challenge](#completing-the-challenge)
11-
a. [TODO:](#step-1-todo)
12+
a. [TODO:](#step-1-todo)
1213

1314
## Overview
15+
1416
Your task is to complete the following programming exercise to show us some of your code! This exercise is based on work that DataMade does every day: pulling data from the web, debugging tricky code, and presenting information to the world.
1517

1618
Submissions should be submitted as a pull request against your fork of this original repository. **Make sure to make your pull request against your own fork of the repository, not the original DataMade repository**.
@@ -19,20 +21,20 @@ There’s no time limit, but don’t feel the need to go over the top with your
1921

2022
We’ll be evaluating whether the code works, as well as its quality. Before submitting, make sure that your code does what you expect it to do, that it’s clean and neat enough to meet your standards, and that you’ve provided us some instructions on how to run it. Be warned: there are some intentional bugs in here that you'll have to iron out to get things working!
2123

22-
*Note: If you would prefer to keep your code challenge private, please share access with the following members of DataMade on GitHub:*
24+
_Note: If you would prefer to keep your code challenge private, please share access with the following members of DataMade on GitHub:_
2325

24-
| Member | GitHub Account |
25-
| ----------- | -------------------------------- |
26-
| Hannah | https://github.com/hancush |
27-
| Derek | https://github.com/derekeder |
28-
| Monkruman | https://github.com/antidipyramid |
29-
| Xavier | https://github.com/xmedr |
30-
| Hayley | https://github.com/haowens |
26+
| Member | GitHub Account |
27+
| --------- | -------------------------------- |
28+
| Hannah | https://github.com/hancush |
29+
| Derek | https://github.com/derekeder |
30+
| Monkruman | https://github.com/antidipyramid |
31+
| Xavier | https://github.com/xmedr |
32+
| Hayley | https://github.com/haowens |
3133

3234
Keep in mind that you cannot create a private fork of a public repository on GitHub, so you’ll need to [follow these instructions](https://gist.github.com/0xjac/85097472043b697ab57ba1b1c7530274) to create a private copy of the repo.
3335

34-
3536
## Installation
37+
3638
Development requires a local installation of [Docker](https://docs.docker.com/get-started/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/). These are the only two system-level dependencies you should need.
3739

3840
Once you have Docker and Docker Compose installed, build the application containers:
@@ -50,7 +52,9 @@ docker compose up
5052
The app will log to the console, and you should be able to visit it at http://localhost:8000
5153

5254
## Completing the Challenge
55+
5356
Once you have the app up and running on your computer, you'll need to flesh out certain code blocks to make the map functional.
5457

5558
### Step 1: TODO:
56-
TODO:
59+
60+
TODO:

map/templates/base.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,8 @@
137137
<!-- Load extra external scripts -->
138138
{% block extra_js %}{% endblock %}
139139

140-
141-
142-
140+
141+
142+
143143
</body>
144144
</html>
145-

map/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class Home(TemplateView):
1616

1717
class MapDataView(APIView):
1818
def get(self, request):
19-
DATA_DIR = os.path.join(os.getcwd(), 'data/raw')
19+
DATA_DIR = os.path.join(os.getcwd(), "data/raw")
2020
response = {"restaurants": [], "community_areas": {}}
2121

2222
# Load in the csv of restaurants

0 commit comments

Comments
 (0)