Some test improvements and fixes (#10356)

Author: andreasjordan

tests/Add-DbaComputerCertificate.Tests.ps1

@@ -68,6 +68,7 @@ Describe $CommandName -Tag UnitTests {
                     SecurePassword = $pfxPassword
                     Flag           = @("UserProtected", "NonExportable")
                     Confirm        = $false
+                    WarningAction  = "SilentlyContinue"
                     ErrorAction    = "SilentlyContinue"
                 }
                 $null = Add-DbaComputerCertificate @splatAddCertificate

tests/Add-DbaInstanceList.Tests.ps1

@@ -26,7 +26,7 @@ Describe $CommandName -Tag IntegrationTests {
     }
 
     AfterAll {
-        $null = Remove-DbaInstanceList -SqlInstance $instanceName -Confirm:$false -ErrorAction SilentlyContinue
+        $null = Remove-DbaInstanceList -SqlInstance $instanceName -ErrorAction SilentlyContinue
     }
 
     Context "adds instances to the list" {

tests/Add-DbaServerRoleMember.Tests.ps1

@@ -57,7 +57,7 @@ Describe $CommandName -Tag IntegrationTests {
             Login       = $login1, $login2
         }
         $null = Remove-DbaLogin @splatRemoveLogin
-        $null = Remove-DbaServerRole -SqlInstance $TestConfig.InstanceSingle -ServerRole $customServerRole -Confirm:$false
+        $null = Remove-DbaServerRole -SqlInstance $TestConfig.InstanceSingle -ServerRole $customServerRole
 
         $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
     }
@@ -105,7 +105,7 @@ Describe $CommandName -Tag IntegrationTests {
 
         It "Adds Login to Roles via piped input from Get-DbaServerRole" {
             $serverRole = Get-DbaServerRole -SqlInstance $server -ServerRole $fixedServerRoles[0]
-            $serverRole | Add-DbaServerRoleMember -Login $login2 -Confirm:$false
+            $serverRole | Add-DbaServerRoleMember -Login $login2
 
             $roleAfter = Get-DbaServerRole -SqlInstance $server -ServerRole $fixedServerRoles[0]
             $roleAfter.EnumMemberNames() | Should -Contain $login2

tests/CLAUDE.md

@@ -100,7 +100,7 @@ Describe $CommandName -Tag IntegrationTests {
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
         # Cleanup all created objects.
-        $null = Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $testDbName -Confirm:$false -ErrorAction SilentlyContinue
+        $null = Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $testDbName -ErrorAction SilentlyContinue
 
         # Remove the backup directory.
         Remove-Item -Path $backupPath -Recurse -ErrorAction SilentlyContinue
@@ -354,7 +354,7 @@ Describe $CommandName -Tag IntegrationTests {
         # Clean up all resources with error suppression
         Remove-Item -Path $backupPath -Recurse -ErrorAction SilentlyContinue
         Remove-Item -Path $filesToRemove -ErrorAction SilentlyContinue
-        Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $databasesToCleanup -Confirm:$false -ErrorAction SilentlyContinue
+        Remove-DbaDatabase -SqlInstance $TestConfig.instance2 -Database $databasesToCleanup -ErrorAction SilentlyContinue
     }
 
     # Test code here

tests/Compare-DbaDbSchema.Tests.ps1

@@ -257,7 +257,7 @@ Describe $CommandName -Tag IntegrationTests {
         # We want to run all commands in the AfterAll block with EnableException to ensure that the test fails if the cleanup fails.
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
-        $null = Remove-DbaDatabase -SqlInstance $TestConfig.InstanceSingle -Database $dbSourceName, $dbTargetName -Confirm:$false
+        $null = Remove-DbaDatabase -SqlInstance $TestConfig.InstanceSingle -Database $dbSourceName, $dbTargetName
 
         Remove-Item -Path $testFolder -Recurse -ErrorAction SilentlyContinue
 

tests/Copy-DbaAgentJobStep.Tests.ps1

@@ -69,8 +69,8 @@ Describe $CommandName -Tag IntegrationTests {
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
         # Cleanup all created jobs
-        $null = Remove-DbaAgentJob -SqlInstance $TestConfig.InstanceCopy1 -Job $sourceJobName, $pipelineJobName -Confirm:$false -ErrorAction SilentlyContinue
-        $null = Remove-DbaAgentJob -SqlInstance $TestConfig.InstanceCopy2 -Job $sourceJobName, $pipelineJobName -Confirm:$false -ErrorAction SilentlyContinue
+        $null = Remove-DbaAgentJob -SqlInstance $TestConfig.InstanceCopy1 -Job $sourceJobName, $pipelineJobName -ErrorAction SilentlyContinue
+        $null = Remove-DbaAgentJob -SqlInstance $TestConfig.InstanceCopy2 -Job $sourceJobName, $pipelineJobName -ErrorAction SilentlyContinue
     }
 
     Context "Command synchronizes job steps properly" {

tests/Get-DbaExternalProcess.Tests.ps1

@@ -25,10 +25,10 @@ Describe $CommandName -Tag IntegrationTests {
         # We want to run all commands in the BeforeAll block with EnableException to ensure that the test fails if the setup fails.
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
-        $computerName = Resolve-DbaComputerName -ComputerName $TestConfig.InstanceSingle -Property ComputerName
+        $computerName = Resolve-DbaComputerName -ComputerName $TestConfig.InstanceRestart -Property ComputerName
 
         # Setup xp_cmdshell to create external processes for testing
-        $null = Invoke-DbaQuery -SqlInstance $TestConfig.InstanceSingle -Query "
+        $null = Invoke-DbaQuery -SqlInstance $TestConfig.InstanceRestart -Query "
         -- To allow advanced options to be changed.
         EXECUTE sp_configure 'show advanced options', 1;
         GO
@@ -47,7 +47,7 @@ Describe $CommandName -Tag IntegrationTests {
         Set-Content -Path $sqlFile -Value "xp_cmdshell 'powershell -command ""sleep 5""'"
 
         # Run sql file to start external process
-        Start-Process -FilePath sqlcmd -ArgumentList "-S $($TestConfig.InstanceSingle) -i $sqlFile" -NoNewWindow -RedirectStandardOutput null
+        Start-Process -FilePath sqlcmd -ArgumentList "-S $($TestConfig.InstanceRestart) -i $sqlFile" -NoNewWindow -RedirectStandardOutput null
 
         # We want to run all commands outside of the BeforeAll block without EnableException to be able to test for specific warnings.
         $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
@@ -58,7 +58,7 @@ Describe $CommandName -Tag IntegrationTests {
         $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
         # Cleanup: Disable xp_cmdshell for security
-        $null = Invoke-DbaQuery -SqlInstance $TestConfig.InstanceSingle -Query "
+        $null = Invoke-DbaQuery -SqlInstance $TestConfig.InstanceRestart -Query "
         EXECUTE sp_configure 'xp_cmdshell', 0;
         GO
         RECONFIGURE;
@@ -68,17 +68,20 @@ Describe $CommandName -Tag IntegrationTests {
         RECONFIGURE;
         GO"
 
-        # remove sql file
+        # Restart the SQL Service to ensure we can remove the temporary file.
+        $null = Restart-DbaService -ComputerName $TestConfig.InstanceRestart -Type Engine -Force
         Remove-Item -Path $sqlFile
 
         $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
     }
 
     Context "Can get an external process" {
         It "returns a process" {
-            Start-Sleep -Seconds 1
-            $results = Get-DbaExternalProcess -ComputerName $computerName | Where-Object Name -eq "cmd.exe"
-            Start-Sleep -Seconds 5
+            1..10 | ForEach-Object {
+                $results = Get-DbaExternalProcess -ComputerName $computerName
+                if ($results) { break }
+                Start-Sleep -Milliseconds 500
+            }
             $results.ComputerName | Should -Be $computerName
             $results.Name | Should -Be "cmd.exe"
             $results.ProcessId | Should -Not -Be $null

tests/Get-DbaInstanceList.Tests.ps1

@@ -22,7 +22,7 @@ Describe $CommandName -Tag IntegrationTests {
     }
 
     AfterAll {
-        $null = Remove-DbaInstanceList -SqlInstance $instanceName -Confirm:$false -ErrorAction SilentlyContinue
+        $null = Remove-DbaInstanceList -SqlInstance $instanceName -ErrorAction SilentlyContinue
     }
 
     Context "returns the instance list" {