Update-SqlPermission - Fix SMO reader conflicts during permission sync (review of #10291)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: potatoqualitee

docs/trackers/features/commit-bug-review-TRACKER.md

@@ -103,7 +103,7 @@ Find real bugs (logic errors, null refs, incorrect behavior) and fix them. Skip
 | df60d986f | Export-DbaUser - Add schema ownership to exported scripts (#10275) | DONE | Guarded SQL Server 2000 schema ownership scripting and added regression coverage. |
 | 7b349b546 | Test-DbaPath - Handle xp_fileexist execution failures gracefully (#10288) | DONE | Restored -EnableException behavior for xp_fileexist failures and added unit regression tests. |
 | 89c06e287 | Invoke-DbaCycleErrorLog - Fix example command names (#10290) | DONE | Reviewed help-text-only example-name fix; no bugs found. |
-| 899cdc30c | Update-SqlPermission - Remove unnecessary SqlConnectionObject.Close() calls (#10291) | PENDING | |
+| 899cdc30c | Update-SqlPermission - Remove unnecessary SqlConnectionObject.Close() calls (#10291) | DONE | Materialized SMO enumerations to avoid open DataReader conflicts and added a unit regression test. |
 | 97d03bee3 | Restore-DbaDatabase - Add -StopAtLsn parameter for LSN-based restore (#10245) | PENDING | |
 | 1fdfddee6 | New-DbaFirewallRule - Fix binary path extraction and remove dead code (#10294) | PENDING | |
 | aaa8f9eaa | Add ReleaseDate for SQL Server releases to buildref-index / Get-DbaBuild / Test-DbaBuild / Add -MaxTimeBehind (#10277) | PENDING | |

private/functions/Update-SqlPermission.ps1

@@ -61,7 +61,7 @@ function Update-SqlPermission {
     }
 
     # Server Roles: sysadmin, bulklogin, etc
-    foreach ($role in $SourceServer.Roles) {
+    foreach ($role in @($SourceServer.Roles)) {
         $roleName = $role.Name
         $destRole = $DestServer.Roles[$roleName]
 
@@ -107,7 +107,7 @@ function Update-SqlPermission {
         }
     }
 
-    $ownedJobs = $SourceServer.JobServer.Jobs | Where-Object OwnerLoginName -eq $loginName
+    $ownedJobs = @($SourceServer.JobServer.Jobs | Where-Object OwnerLoginName -eq $loginName)
     foreach ($ownedJob in $ownedJobs) {
         if ($null -ne $DestServer.JobServer.Jobs[$ownedJob.Name]) {
             if ($Pscmdlet.ShouldProcess($destination, "Changing of job owner to $newLoginName for $($ownedJob.Name).")) {
@@ -205,7 +205,7 @@ function Update-SqlPermission {
     }
 
     # For Sync, if info doesn't exist in EnumDatabaseMappings, then no big deal.
-    foreach ($db in $DestLogin.EnumDatabaseMappings()) {
+    foreach ($db in @($DestLogin.EnumDatabaseMappings())) {
         $dbName = $db.DbName
         $destDb = $DestServer.Databases[$dbName]
         $sourceDb = $SourceServer.Databases[$dbName]
@@ -288,7 +288,7 @@ function Update-SqlPermission {
     }
 
     # Adding database mappings and securables
-    foreach ($db in $SourceLogin.EnumDatabaseMappings()) {
+    foreach ($db in @($SourceLogin.EnumDatabaseMappings())) {
         $dbName = $db.DbName
         $destDb = $DestServer.Databases[$dbName]
         $sourceDb = $SourceServer.Databases[$dbName]
@@ -347,7 +347,7 @@ function Update-SqlPermission {
                 }
             } else {
                 # Database Roles: db_owner, db_datareader, etc
-                foreach ($role in $sourceDb.Roles) {
+                foreach ($role in @($sourceDb.Roles)) {
                     if ($role.EnumMembers() -contains $loginName) {
                         $roleName = $role.Name
                         $destDbRole = $destDb.Roles[$roleName]